GameWrapper: Castlevania - The Adventure (GB) #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baekalfen
reviewed
Feb 8, 2025
Owner
Baekalfen
left a comment
Baekalfen
left a comment
There was a problem hiding this comment.
Looks good. I'll see if it compiles etc. And then I'll probably have to make a faux test, as I don't own this game. Maybe I'll find it in time.
Contributor
Author
|
Thank you very much for the code review. I will probably add some methods like set_health or set_lives_left, and maybe other attributes. I can also take the opportunity to create the "vrai" tests. So if you want, don't worry about merging until further notice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Game Wrapper for Castlevania: The Adventure (GB).