Merged
Conversation
added 2 commits
March 30, 2026 12:56
Aboruhen
requested changes
Mar 30, 2026
Collaborator
Aboruhen
left a comment
Aboruhen
left a comment
There was a problem hiding this comment.
Changes have to be well-organized to make future code easy to read and maintain.
stream-investment/investment-core/src/main/java/com/backbase/stream/investment/Asset.java
Show resolved
Hide resolved
...ore/src/main/java/com/backbase/stream/investment/service/InvestmentAssetUniverseService.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/com/backbase/stream/investment/service/InvestmentAssetUniverseService.java
Show resolved
Hide resolved
...ore/src/main/java/com/backbase/stream/investment/service/InvestmentAssetUniverseService.java
Show resolved
Hide resolved
...ore/src/main/java/com/backbase/stream/investment/service/InvestmentAssetUniverseService.java
Show resolved
Hide resolved
Aboruhen
reviewed
Apr 2, 2026
|
Aboruhen
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BSJ Investment data setup currently patches objects without verifying if the same data already exists. This leads to redundant updates, particularly for Asset Universe due to the absence of bulk insert functionality. Fix for the same
Checklist