-
Notifications
You must be signed in to change notification settings - Fork 152
Add Xcode 26 CI jobs for iOS and macOS #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CedricGuillemet
wants to merge
9
commits into
BabylonJS:master
Choose a base branch
from
CedricGuillemet:test/xcode-26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
11a5d4d
Add Xcode 26 CI jobs for iOS and macOS
CedricGuillemet 08f1008
Fix deprecated interfaceOrientation on iOS 26
CedricGuillemet 815c4cf
Fix deprecated interfaceOrientation in CameraDevice on iOS 26
CedricGuillemet 4fe2bb0
Fix UIScreen.mainScreen deprecation in iOS 26
CedricGuillemet 04d64b5
refactor ios checks
CedricGuillemet 7cba42b
Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…
CedricGuillemet 3fb5579
Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…
CedricGuillemet 80f1228
use 26.4
CedricGuillemet 79a50cf
back to Xcode 26.3
CedricGuillemet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,15 @@ | |
| #import <QuartzCore/QuartzCore.h> | ||
| #import <UIKit/UIKit.h> | ||
|
|
||
|
|
||
| namespace | ||
| { | ||
| bool IsValidScale(float scale) | ||
| { | ||
| return !std::isinf(scale) && scale > 0; | ||
| } | ||
| } | ||
|
|
||
| namespace Babylon::Graphics | ||
| { | ||
| void DeviceImpl::ConfigureBgfxPlatformData(bgfx::PlatformData& pd, WindowT window) | ||
|
|
@@ -19,12 +28,32 @@ | |
| float DeviceImpl::GetDevicePixelRatio(WindowT window) | ||
| { | ||
| // contentsScale can return 0 if it hasn't been set yet. | ||
| // Fallback to the scale from the main screen. | ||
| float scale = static_cast<float>(((CAMetalLayer*)window).contentsScale); | ||
| if (std::isinf(scale) || scale <= 0) | ||
| if (IsValidScale(scale)) | ||
| { | ||
| scale = UIScreen.mainScreen.scale; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure I understand what it's doing here. Does this code actually work? The documentation says traitCollection.displayScale is 0.0 by default. https://developer.apple.com/documentation/uikit/uitraitcollection/displayscale?language=objc FYI @ryantrem |
||
| return scale; | ||
| } | ||
| return scale; | ||
|
|
||
| // Prefer getting the scale from the active window scene's trait collection. | ||
| if (@available(iOS 17.0, *)) | ||
| { | ||
| for (UIScene* scene in UIApplication.sharedApplication.connectedScenes) | ||
| { | ||
| if ([scene isKindOfClass:[UIWindowScene class]]) | ||
| { | ||
| scale = static_cast<float>(((UIWindowScene*)scene).traitCollection.displayScale); | ||
| if (IsValidScale(scale)) | ||
| { | ||
| return scale; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Fallback for older iOS versions or if no active scene was found. | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" | ||
| return UIScreen.mainScreen.scale; | ||
| #pragma clang diagnostic pop | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.