glTF Exporter: Fix light direction calculation #16721
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16721/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16721/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16721/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
| const direction = TmpVectors.Vector3[0]; | ||
| babylonNode.direction.normalizeToRef(direction); |
There was a problem hiding this comment.
Why change this? It's more concise with the original.
The previous light direction calculation didn't account for when the Babylon light direction matched glTF's. This would result NaN values in RotationAxisToRef, as the rotation axis would be (0,0,0), and its length (0) used as a divisor.
I noticed we already have a function to do what we need for the light direction calculation--
FromUnitVectorsToRef-- so I've replaced the whole thing with that. Much simpler.(Bonus: I also noticed that the lights in our glTF light export test don't use glTF falloff, so I've earmarked that change in this PR.)