Updated cleaning methodology to clean correct files for viralrecon#692
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
black and flake8).templates/services.json.assets/reports/md/template.mdis added.assets/reports/results/template.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).templates/sftp_user.jsonPR description
Closes #311.
Currently, depending on the protocol defined when running the viralrecon pipeline,
.sorted.bamfiles should be deleted or not. To handle this situation, the following changes are suggested by this PR:services.jsonhas a new field:clean_script, by which it will be possible to indicate if a specific cleaning script should be used to clean files associated with that specific service. For now, this is only useful for viralrecon, but could be used for other services in the future.assets/utils, a new script calledviralrecon_clean.pyis stored. This script is indicated inservices.json, and the clean module will use this auxiliary script to get the service's protocol from theviralrecon_params.ymlfile and, depending on this, delete or not the appropriate BAM files.services.json.