Broke out baseline correction implementation into separate file, prep…#10
Open
jakubglowacki-uol wants to merge 1 commit intodevfrom
Open
Broke out baseline correction implementation into separate file, prep…#10jakubglowacki-uol wants to merge 1 commit intodevfrom
jakubglowacki-uol wants to merge 1 commit intodevfrom
Conversation
…aring to later select between different methods. Broke out peak_fitting_helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two small changes, breaking out baseline fitting implementation and peak fitting helpers util files, as per your last email. I'd consider this issue ready to close after this, as future changes along these lines will be minor and not structure changing, aka we can tick off the big refactoring job. I'd consider putting testing on the backburner and next focusing on UI portability (electron wrapper/installation).