Open
Conversation
|
My opinion here: Let's hold off on merging in this pull request. Instead of having separate read/write processors, we should consider just copying most of Alex's code into preprocessor.py. Cross-reference: #7 |
|
That sounds good. If you could keep it modular, it would make it easier for me to change the format of Alex's mySQL models. I just want to change some names - trivial, it just happens to be how the aggregator expects the db. |
|
Okay, so when I copy it over, I will try to keep it modular as best as I can. Cross-reference: #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.