Skip to content

Fix issue with CheckAssemblyInfo incorrectly checking itself as AssemblyInfo file #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsakNaslundBh wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix issue with CheckAssemblyInfo incorrectly checking itself as AssemblyInfo file #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*

Check failure on line 1 in CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs

View check run for this annotation

BHoMBot-CI / project-compliance

CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs#L1 

Assembly Version should be set to 9.0.0.0

Check failure on line 1 in CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs

View check run for this annotation

BHoMBot-CI / project-compliance

CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs#L1 

Assembly File Version should be set to 9.1.0.0

Check failure on line 1 in CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs

View check run for this annotation

BHoMBot-CI / project-compliance

CodeComplianceTest_Engine/Compute/CheckAssemblyInfo.cs#L1 

Assembly Description should contain the URL to the GitHub organisation which owns the repository
* This file is part of the Buildings and Habitats object Model (BHoM)
* Copyright (c) 2015 - 2025, the respective contributors. All rights reserved.
*
Expand Down Expand Up @@ -45,7 +45,10 @@
{
public static TestResult CheckAssemblyInfo(this string assemblyInfoPath, string assemblyDescriptionOrg)
{
if (!assemblyInfoPath.EndsWith("AssemblyInfo.cs"))
if(string.IsNullOrWhiteSpace(assemblyInfoPath))
return Create.TestResult(TestStatus.Pass);

if (Path.GetFileName(assemblyInfoPath) != "AssemblyInfo.cs")
return Create.TestResult(TestStatus.Pass);

if (!File.Exists(assemblyInfoPath))
Expand Down