Skip to content

Updated floor outline using SketchEditScope #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WojciechBuda00 wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Updated floor outline using SketchEditScope #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
69a3d80
initial commit
pawelbaran Jan 13, 2026
267aa7d
inspiration how to add a follow up transaction on push
pawelbaran Jan 15, 2026
43ec45e
set with SlabShapeEditor - fix with slope arrow
WojciechBuda00 Jan 22, 2026
788fc89
slope arrow fixed
WojciechBuda00 Jan 26, 2026
1ce7f7a
Update description attributes and correct slope calculation methods
WojciechBuda00 Feb 2, 2026
5588c71
Tweaks - moved IsValid method to Query and changed errorMsg to warni…
WojciechBuda00 Feb 5, 2026
244a8bc
Tweaks and clean up
WojciechBuda00 Feb 10, 2026
8f6afa1
Coordinates fixed
WojciechBuda00 Mar 19, 2026
adaa5b7
Slope Arrow and Coordinates tweaks
WojciechBuda00 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 70 additions & 38 deletions Revit_Core_Adapter/AdapterActions/Push.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
using BH.oM.Adapters.Revit.Elements;
using BH.oM.Base;
using BH.Revit.Engine.Core;
using System;
using System.Collections.Generic;
using System.Linq;

Expand Down Expand Up @@ -60,7 +61,7 @@ public override List<object> Push(IEnumerable<object> objects, string tag = "",
BH.Engine.Base.Compute.RecordError("BHoM objects could not be removed because another transaction is open in Revit.");
return new List<object>();
}

// If unset, set the pushType to AdapterSettings' value (base AdapterSettings default is FullCRUD). Disallow the unsupported PushTypes.
if (pushType == PushType.AdapterDefault)
pushType = PushType.UpdateOrCreateOnly;
Expand All @@ -69,7 +70,7 @@ public override List<object> Push(IEnumerable<object> objects, string tag = "",
BH.Engine.Base.Compute.RecordError("Full Push is currently not supported by Revit_Toolkit, please use Create, UpdateOnly or DeleteThenCreate instead.");
return new List<object>();
}

// Set config
RevitPushConfig pushConfig = actionConfig as RevitPushConfig;
if (pushConfig == null)
Expand All @@ -81,7 +82,7 @@ public override List<object> Push(IEnumerable<object> objects, string tag = "",
// Suppress warnings
if (UIControlledApplication != null && pushConfig.SuppressFailureMessages)
UIControlledApplication.ControlledApplication.FailuresProcessing += ControlledApplication_FailuresProcessing;

// Process the objects (verify they are valid; DeepClone them, wrap them, etc).
IEnumerable<IBHoMObject> objectsToPush = ProcessObjectsForPush(objects, pushConfig); // Note: default Push only supports IBHoMObjects.

Expand Down Expand Up @@ -131,6 +132,7 @@ public override List<object> Push(IEnumerable<object> objects, string tag = "",
{
List<string> distinctNames = group.Select(x => x.Name).Distinct().ToList();
if (distinctNames.Count > 1)

BH.Engine.Base.Compute.RecordWarning($"BHoM objects with names {string.Join(", ", distinctNames)} correspond to the same Revit assembly that has finally been named {group.Key.AssemblyTypeName}.");
}
}
Expand All @@ -149,55 +151,85 @@ public override List<object> Push(IEnumerable<object> objects, string tag = "",

private List<IBHoMObject> PushToRevit(Document document, IEnumerable<IBHoMObject> objects, PushType pushType, RevitPushConfig pushConfig, string transactionName)
{

SketchUpdateQueue.SketchUpdates.Clear();

List<IBHoMObject> pushed = new List<IBHoMObject>();
using (Transaction transaction = new Transaction(document, transactionName))

using (TransactionGroup tg = new TransactionGroup(document, transactionName))
{
transaction.Start();
tg.Start();

if (pushType == PushType.CreateOnly)
pushed = Create(objects, pushConfig);
else if (pushType == PushType.CreateNonExisting)
using (Transaction transaction = new Transaction(document, transactionName))
{
IEnumerable<IBHoMObject> toCreate = objects.Where(x => x.Element(document) == null);
pushed = Create(toCreate, pushConfig);
}
else if (pushType == PushType.DeleteThenCreate)
{
List<IBHoMObject> toCreate = new List<IBHoMObject>();
foreach (IBHoMObject obj in objects)
transaction.Start();

if (pushType == PushType.CreateOnly)
pushed = Create(objects, pushConfig);
else if (pushType == PushType.CreateNonExisting)
{
Element element = obj.Element(document);
if (element == null || Delete(element.Id, document, false).Count() != 0)
toCreate.Add(obj);
IEnumerable<IBHoMObject> toCreate = objects.Where(x => x.Element(document) == null);
pushed = Create(toCreate, pushConfig);
}

pushed = Create(toCreate, pushConfig);
}
else if (pushType == PushType.UpdateOnly)
{
foreach (IBHoMObject obj in objects)
else if (pushType == PushType.DeleteThenCreate)
{
List<IBHoMObject> toCreate = new List<IBHoMObject>();
foreach (IBHoMObject obj in objects)
{
Element element = obj.Element(document);
if (element == null || Delete(element.Id, document, false).Count() != 0)
toCreate.Add(obj);
}

pushed = Create(toCreate, pushConfig);
}
else if (pushType == PushType.UpdateOnly)
{
Element element = obj.Element(document);
if (element != null && Update(element, obj, pushConfig))
pushed.Add(obj);
foreach (IBHoMObject obj in objects)
{
Element element = obj.Element(document);
if (element != null && Update(element, obj, pushConfig))
pushed.Add(obj);
}
}
else if (pushType == PushType.UpdateOrCreateOnly)
{
List<IBHoMObject> toCreate = new List<IBHoMObject>();
foreach (IBHoMObject obj in objects)
{
Element element = obj.Element(document);
if (element != null && Update(element, obj, pushConfig))
pushed.Add(obj);
else if (element == null || Delete(element.Id, document, false).Count() != 0)
toCreate.Add(obj);
}

pushed.AddRange(Create(toCreate, pushConfig));
}

transaction.Commit();
}
else if (pushType == PushType.UpdateOrCreateOnly)

if (SketchUpdateQueue.SketchUpdates.Count > 0)
{
List<IBHoMObject> toCreate = new List<IBHoMObject>();
foreach (IBHoMObject obj in objects)
foreach (Action call in SketchUpdateQueue.SketchUpdates)
{
Element element = obj.Element(document);
if (element != null && Update(element, obj, pushConfig))
pushed.Add(obj);
else if (element == null || Delete(element.Id, document, false).Count() != 0)
toCreate.Add(obj);
try
{
call.Invoke();
}
catch (Exception ex)
{
string errorMsg = $"Sketch update failed: {ex.Message}";
if (ex.InnerException != null)
errorMsg += $" Inner: {ex.InnerException.Message}";

BH.Engine.Base.Compute.RecordError(errorMsg);
}
}

pushed.AddRange(Create(toCreate, pushConfig));
}

transaction.Commit();
tg.Assimilate();
}

return pushed;
Expand Down
Loading