Fix user-scoped database list ErrorResponse failure#16
Merged
Conversation
When BERDL's get_namespace_prefix(tenant=None) returns an ErrorResponse instead of a NamespacePrefixResponse, the user database list fails with a confusing AttributeError. Fix by falling back to deriving the user namespace prefix from the username (via get_my_groups) when the call fails for user scope. Also add ErrorResponse detection to both BERDL wrappers so failures surface clear error messages.
|
Prerelease: pr-16 Wheel will be attached once the build completes. Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_namespace_prefix(tenant=None)returns anErrorResponseinstead ofNamespacePrefixResponse, the user database list in the Data Dictionary crashes with'ErrorResponse' object has no attribute 'username'DatabasesHandler: whenget_namespace_prefixfails for user scope, derive the prefix fromget_my_groups()username (u_{username}__)ErrorResponsedetection to bothget_my_groupsandget_namespace_prefixBERDL wrappers so failures surface clear error messages instead of crypticAttributeErrorsTest plan
get_namespace_prefix(tenant=None)returns ErrorResponse — should now show databases correctly