-
Notifications
You must be signed in to change notification settings - Fork 0
[마이그레이션] RTK Query 마이그레이션 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…api-migration [마이그레이션] tanstack query 기초 세팅 및 club api 변경
[마이그레이션] club, category, forceUpdate, benefit 관련 api 마이그레이션
…ang-s-h [어드민]history,member,notice,owner,ownerRequest,review,user 마이그레이션
…gration-3-kang-s-h Revert "[어드민]history,member,notice,owner,ownerRequest,review,user 마이그레이션"
[마이그레이션] RTK Query -> Tanstack Query 마이그레이션 - abtest, address, auth, banner, bannerCategory
Tanstack Query 마이그레이션 - room, shop, shopMenu, updateList, upload
[오류 수정] 불필요한 import 삭제
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ff1451
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새롭게 구조 적용하는거라 힘들었을텐데 참여하신 분들 모두 고생하셨습니다!
혜준님, 동훈님, 성훈님 작업은 개별 pr에서 확인했어서 도훈님 부분만 보고 궁금한 점이 있어 질문 하나 남겼습니다!
| const { mutate: changePasswordMutation } = useMutation({ | ||
| mutationFn: changePassword, | ||
| onSuccess: () => { | ||
| message.success('비밀번호 변경 완료'); | ||
| handleModalClose(); | ||
| }, | ||
| onError: (error) => { | ||
| message.error(error.message || '비밀번호 변경 실패'); | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 mutation 쿼리들은 별도 파일로 분리하여 관리하는 것을 보이는데 비밀번호 변경 하나뿐이어서 별도로 관리하지 않는 것이 맞는지 질문드립니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다! mutation은 자유롭게 적용하도록 했습니다.
해당 훅을 재사용한다면, 별도로 분리하여 사용하고 그렇지 않다면 컴포넌트에 직접 정의해서 사용하도록 했습니다.
What is this PR? 🔍
Changes 📝
폴더 구조
마이그레이션 담당
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint