Skip to content

Conversation

@dooohun
Copy link
Contributor

@dooohun dooohun commented Oct 2, 2025

What is this PR? 🔍

Changes 📝

  • RTK Query를 TanStack Query로 마이그레이션
  • baseURL 관리 apiClient 작업
  • queryOptions 기반 queryFactory 관리 방식으로 변경

폴더 구조

// 참고
src
├─ queryFactory
   ├─ classroomQueires.ts
   └─ ~~
└─ apis/
   ├─ apiClient.ts
   └─ classroom.ts

마이그레이션 담당

  • abtest, address, auth, banner, bannerCategory - @dooohun
  • benefit, category, club, clubRequest, forceUpdate - @hyejun0228
  • history, member, notice, owner, ownerRequest, review - @kang-s-h
  • room, shop, shopMenu, updateList, upload, user - @pcasfs

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

dooohun and others added 30 commits September 25, 2025 00:02
…api-migration

[마이그레이션] tanstack query 기초 세팅 및 club api 변경
[마이그레이션] club, category, forceUpdate, benefit 관련 api 마이그레이션
…ang-s-h

[어드민]history,member,notice,owner,ownerRequest,review,user 마이그레이션
…gration-3-kang-s-h

Revert "[어드민]history,member,notice,owner,ownerRequest,review,user 마이그레이션"
dooohun and others added 20 commits October 1, 2025 09:54
[마이그레이션] RTK Query -> Tanstack Query 마이그레이션 - abtest, address, auth, banner, bannerCategory
Tanstack Query 마이그레이션 - room, shop, shopMenu, updateList, upload
[오류 수정] 불필요한 import 삭제
@dooohun dooohun added the 🔨 Refactor 코드 리팩토링 label Oct 2, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ff1451 ff1451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새롭게 구조 적용하는거라 힘들었을텐데 참여하신 분들 모두 고생하셨습니다!
혜준님, 동훈님, 성훈님 작업은 개별 pr에서 확인했어서 도훈님 부분만 보고 궁금한 점이 있어 질문 하나 남겼습니다!

Comment on lines +30 to +40
const { mutate: changePasswordMutation } = useMutation({
mutationFn: changePassword,
onSuccess: () => {
message.success('비밀번호 변경 완료');
handleModalClose();
},
onError: (error) => {
message.error(error.message || '비밀번호 변경 실패');
},
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 mutation 쿼리들은 별도 파일로 분리하여 관리하는 것을 보이는데 비밀번호 변경 하나뿐이어서 별도로 관리하지 않는 것이 맞는지 질문드립니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞습니다! mutation은 자유롭게 적용하도록 했습니다.
해당 훅을 재사용한다면, 별도로 분리하여 사용하고 그렇지 않다면 컴포넌트에 직접 정의해서 사용하도록 했습니다.

@dooohun dooohun merged commit 4ad296d into develop Oct 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTK Query 마이그레이션

6 participants