Document staging E2E environment#105
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Playwright Hosted Data-FlowOutcome: success This optional check runs the mutation-backed profile flow against a configured hosted dev/staging target with isolated E2E test data. |
Playwright Data-Flow PreviewOutcome: success Captured flow:
Artifacts include screenshots, traces, and recorded video for the flow run. |
Playwright Image DiffOutcome: success Changed screenshot baselines: none in this PR. This check compares public route screenshots against committed baselines. Inline images show only added or modified baseline PNGs. |
Playwright Public Screenshot PreviewOutcome: success Screenshots: all public route checks passed on desktop and mobile. Full screenshot set is available in the artifact. Pixel diff baselines are handled by the separate Playwright Image Diff check. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis docs-only PR records the Vercel
Confidence Score: 4/5Safe to merge — all changes are documentation only, no secret values are exposed, and the documented configuration aligns with the existing env var naming conventions throughout the codebase. The PowerShell-only Convex push command in docs/deployment/convex-environments.md — the new Convex push command block is PowerShell-only. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GitHub Actions\nDeployed Health Checks] -->|VRDEX_HOSTED_E2E_BASE_URL\nVRDEX_HOSTED_E2E_BROWSER_TOKEN| B[Playwright\nstaging-mutation run]
B -->|HTTP requests| C[Vercel staging\nvr-dex-web-env-staging-basicbit.vercel.app]
C -->|NEXT_PUBLIC_CONVEX_URL\nCONVEX_URL| D[Convex dev deployment\nscrupulous-corgi-247]
C -->|VRDEX_ENABLE_E2E_HELPERS=true\nVRDEX_E2E_BROWSER_TOKEN\nVRDEX_E2E_CONVEX_SECRET| C
D -->|VRDEX_ENABLE_E2E_HELPERS=true\nVRDEX_E2E_CONVEX_SECRET| D
E[Developer\nPowerShell] -->|convex dev --once\nCONVEX_DEPLOYMENT=dev:scrupulous-corgi-247| D
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
docs/deployment/convex-environments.md:45-47
**Missing POSIX shell equivalent for Convex push command**
Every other shell command in these docs comes in both a PowerShell and a POSIX shell form (see `playwright-visual-preview.md`, which provides paired `powershell` and `sh` blocks throughout). A developer on Linux or macOS who needs to push Convex functions to the dev deployment has no direct equivalent here and would have to manually translate the `$env:VAR="value"` syntax to `VAR=value` prefix form.
Reviews (1): Last reviewed commit: "Document staging E2E environment" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ```powershell | ||
| $env:CONVEX_DEPLOYMENT="dev:scrupulous-corgi-247"; $env:CONVEX_SELF_HOSTED_URL=""; pnpm exec convex dev --once --typecheck=try --tail-logs=disable | ||
| ``` |
There was a problem hiding this comment.
Every other shell command in these docs comes in both a PowerShell and a POSIX shell form (see playwright-visual-preview.md, which provides paired powershell and sh blocks throughout). A developer on Linux or macOS who needs to push Convex functions to the dev deployment has no direct equivalent here and would have to manually translate the $env:VAR="value" syntax to VAR=value prefix form.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/deployment/convex-environments.md
Line: 45-47
Comment:
**Missing POSIX shell equivalent for Convex push command**
Every other shell command in these docs comes in both a PowerShell and a POSIX shell form (see `playwright-visual-preview.md`, which provides paired `powershell` and `sh` blocks throughout). A developer on Linux or macOS who needs to push Convex functions to the dev deployment has no direct equivalent here and would have to manually translate the `$env:VAR="value"` syntax to `VAR=value` prefix form.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
What changed
Testing
Risk
Docs-only repository change. Provider settings were already created and validated.