Move nagivateToLoginRequestUrl out of Configuration
#7855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Suppress false-positive CodeQL finding in NavigationClient
Updates the remove access token cache logic to perform its steps synchronously. This is a pre-requisite for additional work to handle cache quota errors in the near future. This requires pushing the POP key removal (which is asynchronous) to the background, we will track failures around this in telemetry instead of throwing an error developers can't resolve anyway.
This PR contains the changelogs and version bumps for the MSAL.js 3P releases. Co-authored-by: MSAL.js Release Automation <[email protected]> Co-authored-by: Sameera Gajjarapu <[email protected]>
Bumped to new minor version
1. Updated all msal-node samples to use dotenv 16.5.0 2. Moved dotenv from devDependencies to dependencies in several samples. This change reflects that dotenv is a runtime requirement for these samples since they need to load environment variables during actual execution, not just during development. 3. Run `npm i` in each directory to update package-lock.json files 4. Merged in child: #7824
…7820) Updated code and README
…Machine Learning Managed Identity (#7616) Fixes #7609 If the Machine Learning System Assigned Managed Identity is being used, the "clientid" request parameter will be set to the DEFAULT_IDENTITY_CLIENT_ID environment variable instead of being omitted in the network request. I manually tested this on two different AML clusters - one with SAMI enabled and the other with UAMI enabled.
hectormmg
requested review from
sameerag,
tnorling,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
tnorling
reviewed
Jun 20, 2025
| @@ -46,4 +47,5 @@ export type RedirectRequest = Partial< | |||
| > & { | |||
| scopes: Array<string>; | |||
| redirectStartPage?: string; | |||
| navigateToLoginRequestUrl?: boolean; | |||
There was a problem hiding this comment.
It feels wrong for this to be part of RedirectRequest, what needs to happen to make this only applicable to `handleRedirectPromise?
tnorling
reviewed
Jun 20, 2025
| * @returns Token response or null. If the return value is null, then no auth redirect was detected. | ||
| */ | ||
| async handleRedirectPromise( | ||
| hash?: string | ||
| hash?: string, | ||
| options?: { |
There was a problem hiding this comment.
Can we create a type for options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
navigateToLoginRequestUrlout ofConfiguration.BrowserAuthOptionsand intoRedirectRequestand as an optional parameter inhandleRedirectPromise.