Standalone functions in PCA #7810
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectormmg
requested review from
sameerag,
tnorling,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
tnorling
reviewed
Jun 16, 2025
| */ | ||
| export function initializeServerTelemetryManager( | ||
| apiId: number, | ||
| config: BrowserConfiguration, |
There was a problem hiding this comment.
Do we need the whole config here or can we just pass in the clientId?
tnorling
reviewed
Jun 16, 2025
| // Clear all accounts and tokens | ||
| await browserStorage.clear(correlationId); | ||
| // Clear any stray keys from IndexedDB | ||
| await browserCrypto.clearKeystore(); |
There was a problem hiding this comment.
This feels like something that should be handled by the clear function above. Thoughts?
tnorling
reviewed
Jun 16, 2025
| * @param popupWindow - window that is being monitored | ||
| * @param timeout - timeout for processing hash once popup is redirected back to application | ||
| */ | ||
| export async function monitorPopupForHash( |
There was a problem hiding this comment.
nit: IMO it's preferable to keep all the popup code together in the same file
tnorling
reviewed
Jun 16, 2025
| export async function monitorPopupForHash( | ||
| popupWindow: Window, | ||
| popupWindowParent: Window, | ||
| config: BrowserConfiguration, |
There was a problem hiding this comment.
Do we need to pass in the whole config object or can this accept the timeout & responseMode directly?
There was a problem hiding this comment.
Why not just pass the whole config object around? Is there a penalty for doing so? Minification impact?
tnorling
approved these changes
Jun 16, 2025
shylasummers
approved these changes
Jun 16, 2025
peterzenz
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns the following into standalone exported functions to help minify them on build output:
BaseInteractionClient:getRedirectUri()getDiscoveredAuthorityinitializeServerTelemetryManager()StandardInteractionClient:InitializeAuthorizationRequest()PopupClient:monitorPopupForHash()cleanPopup()