Update test app , Fixes AB#3435630 #2409
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
1 similar comment
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3430520 to an Azure Boards work item. |
rpdome
force-pushed
the
rapong/updatetestapp
branch
from
4581a98 to
a993ba4
Compare
|
✅ Work item link check complete. Description contains link AB#3435630 to an Azure Boards work item. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test app to remove the broker discovery toggle switch and simplify the UI layout. The changes align with updates in the common submodule (referenced in common#2818).
Key changes:
- Removed the "Enable New Broker Discovery" toggle switch from the UI
- Consolidated the broker cache display and clear button into a single layout row
- Updated the "Clear Active Broker Cache" button text to simply "Clear"
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testapps/testapp/src/main/res/values/strings.xml | Shortened the clear button text from "Clear Active Broker Cache" to "Clear" |
| testapps/testapp/src/main/res/layout/fragment_acquire.xml | Removed the broker discovery toggle layout and reorganized the cached broker display with adjusted layout weights |
| testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/AcquireTokenFragment.java | Removed the broker discovery switch field and its associated listener logic |
| common | Updated submodule reference to align with common library changes |
|
LGTM. I would recommend taking a quick look at the LTW tests to see if this change would affect them. |
|
❌ Invalid work item number: AB#3435630 [common#2818. Work item number must be a valid integer. Click here to learn more. |
|
✅ Work item link check complete. Description contains link AB#3435630 to an Azure Boards work item. |
github-actions
bot
changed the title
AB#3435630
Related Common Change