Skip to content

Conversation

@juan-arias
Copy link
Member

Proposed changes

This pull request addresses an issue with the legacy keychain on macOS by updating logging and error handling in the MSIDMacKeychainTokenCache implementation. Instead of creating unimplemented errors for certain methods, the code now logs informational messages and returns early, which should improve clarity when these methods are called in unsupported contexts.

Key changes:

Keychain error handling and logging improvements:

  • Updated jsonObjectsWithKey:serializer:context:error: and saveJsonObject:serializer:key:context:error: in MSIDMacKeychainTokenCache.m to log informational messages instead of generating unimplemented errors, and to return nil or NO as appropriate.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@juan-arias juan-arias requested a review from a team as a code owner November 19, 2025 21:26
@juan-arias juan-arias marked this pull request as draft November 24, 2025 19:51
@juan-arias
Copy link
Member Author

These changes were released manually, they will be merged to dev in #1625

@juan-arias juan-arias closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants