Propagate broker telemetry to CommonCore through Protocol

[kaisong1990]

Proposed changes

This pull request introduces support for passing a telemetry provider throughout the request controller stack in the IdentityCore project. The changes ensure that telemetry data can be collected and propagated as part of authentication flows, which will help with diagnostics and monitoring. The update includes new header and implementation files for telemetry provider interfaces and test providers, and modifies controller constructors and factory methods to accept and store telemetry providers.

Telemetry Provider Integration

• Added references for new telemetry provider interface and test provider files (MSIDTelemetryProviding.h, MSIDTestTelemetryProvider.h, MSIDTestTelemetryProvider.m) to the Xcode project, including build phases and groupings. [1] [2] [3] [4] [5] [6] [7] [8]

• Updated MSIDBaseRequestController and its implementation to accept and store an id<MSIDTelemetryProviding> telemetry property, making it available to all request controllers. [1] [2] [3] [4]

• Modified controller constructors (e.g., MSIDLocalInteractiveController) to accept a telemetry provider parameter and pass it appropriately through initialization. [1] [2]

Factory Method Updates

• Updated MSIDRequestControllerFactory interface and implementation to accept and forward the telemetry provider parameter in all relevant factory methods, ensuring telemetry is consistently propagated to created controllers. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Type of change

• Feature work
• Bug fix
• Documentation
• Engineering change
• Test
• Logging/Telemetry

Risk

• High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
• Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
• Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

[kaisong1990]

Hi @swasti29, can you take a look as well?

[Copilot]

Pull Request Overview

This PR introduces a telemetry provider infrastructure to the IdentityCore project, enabling telemetry data collection and propagation throughout the authentication request flow. A new protocol MSIDTelemetryProviding defines telemetry methods, and this telemetry provider is threaded through controller constructors, factory methods, and token requests to enable diagnostics and monitoring.

• New telemetry provider protocol and test implementation files
• Updated controller initialization to accept and store telemetry providers
• Modified factory methods to propagate telemetry throughout the request stack

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
MSIDTelemetryProviding.h	Defines the telemetry provider protocol interface
MSIDTestTelemetryProvider.h/.m	Implements a test stub for telemetry provider
MSIDClientTelemetryConstants.h/.m	Defines constants for telemetry keys and values
MSIDBaseRequestController.h/.m	Adds telemetry property and constructor parameter
MSIDSilentController.h/.m	Updates initializers to accept telemetry parameter
MSIDBrokerInteractiveController.h/.m	Updates initializers to accept telemetry parameter
MSIDLocalInteractiveController.m	Passes nil telemetry in controller initialization
MSIDRequestControllerFactory.h/.m	Adds telemetry parameter to factory methods
MSIDSilentTokenRequest.h/.m	Adds telemetry property and uses it to log telemetry data
MSIDDefaultSilentTokenRequest.h/.m	Adds telemetry parameter to initializer
MSIDTokenRequestProviding.h	Adds telemetry parameter to protocol method
MSIDDefaultTokenRequestProvider.m	Passes telemetry to silent token request
MSIDLegacyTokenRequestProvider.m	Adds telemetry parameter to protocol implementation
MSIDLegacySilentTokenRequest.m	Passes nil telemetry to parent initializer
MSIDSSORemoteSilentTokenRequest.m	Passes nil telemetry to parent initializer
MSIDHttpRequestErrorHandling.h	Adds telemetry parameter to error handling method
MSIDAADRequestErrorHandler.m	Uses telemetry to log HTTP error handling data
MSIDHttpRequest.h/.m	Adds telemetry provider property and passes it to error handler
Test files	Updated test code to pass telemetry parameter (mostly nil)
project.pbxproj	Registers new telemetry files in Xcode project

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[swasti29]

Changes looks, most of the changes are due to adding new parameter. Please test end 2 end.