Using Baggage to propagate attributes from parent Span, Fixes AB#3262849

[melissaahn]

Summary

The passkey telemetry dashboard (and maybe some others) has had issues with latency due to joins being done between the Fido span and the parent span related to acquire token interactive. These join statements by trace id allowed us to associate attributes (such as tenant id) to the Fido span that weren't available in the context of the Fido classes.
In order to directly save the attributes onto the Fido span itself, we can make use of Otel's Baggage, which is meant to help hold data across multiple spans (from parent to children). We can then use an implementation of Otel's TextMapPropagator to serialize the Otel Context and pass it to the AuthenticationActivity as an Extra (similar to what we are doing for spanContext). This Context can then be accessed by the WebViewClient and Fido related classes, where they will retrieve the Baggage.

This PR has the changes to implement this behavior and adds a few static helper classes for TextMapPropagator and Baggage (the baggage class is more relevant for the corresponding Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3119).

While this PR tackles attribute propagation for AuthorizationActivity specifically, Baggage and the helper classes can be used in other areas of the code where propagation is needed as well.

AB#3262849

[github-actions]

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

[Copilot]

Pull Request Overview

This PR implements the propagation of attributes via OpenTelemetry’s Baggage mechanism to eliminate latency issues caused by join operations between spans. Key changes include:

• Introduction of new helper classes (TextMapPropagatorExtension and BaggageExtension) for injecting and extracting context.
• Updates to AuthorizationActivity, AuthorizationActivityFactory, and related classes to support OTel context propagation.
• Adjustments to tests and build configurations to accommodate the new baggage-based context handling.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/TextMapPropagatorExtension.java	Implements utilities for OTel context injection and extraction.
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/BaggageExtension.java	Adds helper methods for working with baggage in spans.
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java	Introduces additional attribute names for telemetry.
common4j/build.gradle	Adds the OTel SDK dependency.
common/src/test/java/com/microsoft/identity/common/internal/fido/AuthFidoChallengeHandlerTest.kt	Updates tests with new OTel context parameter.
common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java	Refactors span context usage to OTel context.
common/src/main/java/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityFactory.kt	Passes OTel context carrier via intent extras.
common/src/main/java/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivity.java	Extracts and deserializes the OTel context from intent extras.
common/src/main/java/com/microsoft/identity/common/internal/fido/AuthFidoChallengeHandler.kt	Utilizes baggage from the OTel context to set span attributes.
common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java	Adds constant for OTEL context carrier.
changelog.txt	Documents the baggage-based attribute propagation changes.

Comments suppressed due to low confidence (1)

common/src/main/java/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivity.java:77

• [nitpick] Consider extracting the OTEL context deserialization logic into a dedicated helper method to improve readability and reduce duplication between TIRAMISU and earlier Android versions.

carrier = getIntent().getExtras() != null ? getIntent().getExtras().getSerializable(OTEL_CONTEXT_CARRIER, HashMap.class) : new HashMap<>();

[Copilot]

[nitpick] Consider refactoring this anonymous inner class to a lambda expression (if supported by your project’s language version) to improve readability and reduce verbosity.

Suggested change

	final TextMapSetter<Map<String, String>> setter = new TextMapSetter<Map<String, String>>() {
	@Override
	public void set(Map<String, String> carrier, String key, String value) {
	if (carrier != null && key != null && value != null) {
	carrier.put(key, value);
	}
	final TextMapSetter<Map<String, String>> setter = (carrier, key, value) -> {
	if (carrier != null && key != null && value != null) {
	carrier.put(key, value);

[shahzaibj]

Not sure we can do this for libraries. We have to see what is the since increase with adding this here. OneAuth consumes common so we have to be careful. Other 3p apps using MSAL Android could face it too.

Let's do a size analysis before proceeding