Enforce proxy in UrlConnectionHttpClient #2650
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a proxy enforcement mechanism in the UrlConnectionHttpClient for HTTP requests by selecting a proxy via the system ProxySelector and falling back to system properties if necessary.
- Enforces the use of a proxy when creating HttpURLConnection.
- Adds an overloaded method in HttpUrlConnectionFactory to support proxy parameters.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/net/UrlConnectionHttpClient.java | Introduces proxy selection logic and updates connection creation. |
| common4j/src/main/com/microsoft/identity/common/java/net/HttpUrlConnectionFactory.java | Adds an overload to create a HttpURLConnection with a specified proxy. |
common4j/src/main/com/microsoft/identity/common/java/net/UrlConnectionHttpClient.java
Outdated
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/net/UrlConnectionHttpClient.java
Outdated
Show resolved
Hide resolved
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve this issue where the proxy currently isn't enforced #2297
The code is currently untested, im using it as a reference to see if you guys would accept a solution like this if it were to be tested.