[Spector] Test case for ARM multiple services #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
The following packages have already been documented:
|
packages/azure-http-specs/specs/azure/resource-manager/multi-service/tspconfig.yaml
Outdated
Show resolved
Hide resolved
packages/azure-http-specs/specs/azure/resource-manager/multi-service/service2.tsp
Outdated
Show resolved
Hide resolved
added 6 commits
December 10, 2025 18:18
…s_arm-multi-service
…s_arm-multi-service
tadelesh
changed the title
tadelesh
requested review from
bterlson,
iscai-msft,
jhendrixMSFT,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar,
tadelesh and
timotheeguerin
as code owners
commit: |
Collaborator
|
You can try these changes here
|
packages/azure-http-specs/specs/azure/resource-manager/multi-service/service1.tsp
Outdated
Show resolved
Hide resolved
packages/azure-http-specs/specs/azure/resource-manager/multi-service/service1.tsp
Outdated
Show resolved
Hide resolved
packages/azure-http-specs/specs/azure/resource-manager/multi-service/service2.tsp
Outdated
Show resolved
Hide resolved
packages/azure-http-specs/specs/azure/resource-manager/multi-service/service2.tsp
Outdated
Show resolved
Hide resolved
…ervice/service1.tsp Co-authored-by: Weidong Xu <[email protected]>
…ervice/service1.tsp Co-authored-by: Weidong Xu <[email protected]>
…ervice/service2.tsp Co-authored-by: Weidong Xu <[email protected]>
…ervice/service2.tsp Co-authored-by: Weidong Xu <[email protected]>
tadelesh
approved these changes
Dec 19, 2025
lirenhe
reviewed
Dec 23, 2025
|
|
||
| @client({ | ||
| service: [ | ||
| Azure.ResourceManager.MultiService.Compute, |
Member
There was a problem hiding this comment.
Can we add another case of selecting specific version of Compute/ComputeDisk?
I think this should be a supported scenario for compute service.
lirenhe
reviewed
Dec 23, 2025
| properties: { | ||
| provisioningState: "Succeeded", | ||
| }, | ||
| }; |
Member
There was a problem hiding this comment.
Another thing I suggest to verify is the common models/operations between 2 services. Can we add case for it? thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #3538