docs: add local execution journey - #1211
Merged
devanshjainms merged 17 commits intoJul 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end local SDAF deployment journey to the central documentation hub.
Changes:
- Documents prerequisites, deployment, installation, operations, and troubleshooting.
- Covers established and v2 script families and operational safeguards.
- Links the journey from central documentation pages.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
docs/local/README.md |
Introduces the journey and script families. |
docs/local/01-00-prerequisites.md |
Documents prerequisites and version requirements. |
docs/local/02-00-prepare-execution-environment.md |
Covers host and configuration preparation. |
docs/local/03-00-control-plane.md |
Documents control-plane deployment. |
docs/local/04-00-workload-zone.md |
Documents workload-zone deployment. |
docs/local/05-00-sap-system.md |
Documents SAP-system deployment. |
docs/local/06-00-software-and-installation.md |
Covers software download and Ansible installation. |
docs/local/07-00-operations.md |
Covers changes, recovery, state, and removal. |
docs/local/troubleshooting.md |
Adds local-execution troubleshooting guidance. |
docs/index.md |
Links to the local journey. |
docs/deployment-options.md |
Adds the journey to local deployment options. |
Comments suppressed due to low confidence (1)
docs/local/06-00-software-and-installation.md:170
- The menu does not stop after every failure: custom pre- and post-playbook failures are logged and the sequence continues. The retry guidance should warn operators to check those hook results explicitly rather than relying on the wrapper to stop.
Correct the failed prerequisite or task, then rerun the smallest applicable
playbook. The menu stops after a failure, so do not restart a grouped sequence
without identifying the failed playbook and reviewing its progress marker and
idempotence.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/local/02-00-prepare-execution-environment.md:131
- The strict-checking override documented here is ineffective:
configuration_menu.sh:82unconditionally exportsANSIBLE_HOST_KEY_CHECKING=Falseafter the operator launches it, overriding theTruevalue set in this step. This can make an operator believe policy-required host-key enforcement is active when the installation wrapper has disabled it. Document the limitation and require an approved wrapper change for strict checking.
The generated profile also sets `ANSIBLE_HOST_KEY_CHECKING=False`. Before
running configuration, verify each target host key through an approved
out-of-band source. If your security policy requires strict checking,
populate the approved `known_hosts` file and export
`ANSIBLE_HOST_KEY_CHECKING=True` after loading the profile.
hdamecharla
previously approved these changes
Jul 28, 2026
Document the end-to-end local scripted deployment path, including prerequisites, environment preparation, lifecycle stages, operations, and troubleshooting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Clarify retained Terraform apply artifacts and distinguish numbered playbook failures from customer hook failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Use the checkout consumed by configure_deployer.sh, verify the approved commit after clone, and restore reviewed environment values after loading the generated profile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Clarify version resolution, operating-system changes, generated SSH policy, and the maintenance review required before rerunning host preparation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Require an installed authenticated Azure CLI before configure_deployer queries account state, and document its managed-identity host requirement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Document the Ansible wrapper's host-key override and the backend migration performed even during state listing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Align workload-zone checks, troubleshooting artifacts, and control-plane removal paths with local script behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Quote the commit placeholder, use absolute control-plane parameter paths, and document required non-MSI service-principal inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Document host architecture, workload subscription scope, and component BOM values required by the local wrappers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Show unquoted BOM component scalars so download_menu.sh does not retain quote characters in the generated name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Warn that a persisted removal step can make reruns exit successfully while deployer resources remain, and require reviewed component recovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Require Git before cloning and remove the retrieved SSH private key after each configuration-menu run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
List the documented Linux setup versions and distinguish the portable Bash entry points from the Linux-specific setup helper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Describe the setup helper's recognized distributions without treating its code guards as an authoritative support matrix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Document service-principal argument exposure, identity selection after profile loading, and provider-lock requirements for deterministic retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Set workload subscription context for SAP-system deployment and removal, and exclude interrupted control-plane removal from generic retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6d10f85a-7a25-43b0-bcb2-abf87810f1b2
devanshjainms
force-pushed
the
docs/local-execution-journey
branch
from
July 28, 2026 17:38
c1bf2fd to
de3d9dc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/local/06-00-software-and-installation.md:63
- The download creates the aggregated BOM under
save_bom_as, but the laterconfiguration_menu.shinvocation does not read that field; it passes the existingbom_base_namefromsap-parameters.yamlto BOM processing (configuration_menu.sh:188,3.3-bom-processing/tasks/main.yaml:66). Unless these values are explicitly kept equal, installation looks for the pre-download/generated BOM name rather than the aggregated BOM. Setbom_base_nameto the same combined name in this preparation step.
application_bom_name: <APPLICATION_BOM>
database_bom_name: <DATABASE_BOM>
sap_kernel_bom_name: <KERNEL_BOM>
save_bom_as: <COMBINED_BOM_NAME>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local scripted execution is a first-class SDAF deployment model, but the central repository did not provide an end-to-end journey equivalent to the GitHub Actions and Azure DevOps paths.
Solution
Tests
release/july-2026source baseline.git diff --check.Notes
This is phase 2 of the repository documentation modernization. It follows merged PR #1205 and does not change scripts, Terraform, Ansible, pipelines, support policy, or Microsoft Learn content.