Skip to content

Conversation

@jblaz99
Copy link
Contributor

@jblaz99 jblaz99 commented Dec 4, 2025

Description

The code was conditionally setting an ip address offset that broke single subscription deployments. This change removes that conditional.

Issue reference

The issue this PR will close: #1234

@jblaz99 jblaz99 requested a review from a team as a code owner December 4, 2025 21:11
@jblaz99
Copy link
Contributor Author

jblaz99 commented Dec 5, 2025 via email

@jblaz99
Copy link
Contributor Author

jblaz99 commented Dec 5, 2025

The latest failed validation looks unrelated to the fix for the initial failed validation.

@jamasten jamasten changed the base branch from main to pr-1256 January 7, 2026 21:54
@jamasten jamasten merged commit d714bba into Azure:pr-1256 Jan 7, 2026
1 of 2 checks passed
Copy link
Contributor

@jamasten jamasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I will test your changes with an internal feature branch. If everything goes well, I will merge your changes into main.

brsteel pushed a commit that referenced this pull request Jan 10, 2026
* remove conditional offsets for hub and identity subscription ids (#1256)

* remove conditional offsets for hub and identity subscription ids

* Update active-directory-domain-services.bicep

remove unused variables

* Trigger rebuild

---------

Co-authored-by: Jerry Blasdel <[email protected]>

* Added static IP address for key vault

* Removed key vault IP config, Updated ADDS IP offset

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: jblaz99 <[email protected]>
Co-authored-by: Jerry Blasdel <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MLZ: IP conflict with KV and ADDS in single sub deployment

2 participants