Properly initialize content handler logging#828
Open
AndreRicardo-Zoetis wants to merge 6 commits intoAzure:developfrom
Open
Properly initialize content handler logging#828AndreRicardo-Zoetis wants to merge 6 commits intoAzure:developfrom
AndreRicardo-Zoetis wants to merge 6 commits intoAzure:developfrom
Conversation
AndreRicardo-Zoetis
changed the title
Collaborator
|
@AndreRicardo-Zoetis - thanks for the PR. The changes look good, but I’m a bit concerned this could break others who have built custom content download handlers. We may want to consider a backward‑compatible approach (e.g., build flag or runtime check) to support both old and new ABIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know you just cleared all Pull Requests, congrats! 😅
Fix #780 show curl logs.
While testing noticed that logLevel was not passed to contentDownloader, needed to pass logLevel so it works as expected for different
-lparameters.do-client logs were also missing, added initialization now.
deliveryoptimization is harder to test for us but did a full build and could see the
do_downloadlogs now:Other changes: