Use System.Linq.AsyncEnumerable over System.Linq.Async #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates from the System.Linq.Async package to the newer System.Linq.AsyncEnumerable package to avoid naming collisions with .NET 10+ and align with the BCL's incorporation of async LINQ APIs.
Key changes:
- Updated package references from
System.Linq.AsynctoSystem.Linq.AsyncEnumerable - Added
StringComparer.Ordinalparameter toToDictionaryAsynccall to match new API signature - Suppressed TFM support build warnings across multiple project files
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updated package versions for System.Linq.AsyncEnumerable (10.0.0) and Microsoft.Bcl.AsyncInterfaces (10.0.0) |
| src/DurableTask.AzureStorage/DurableTask.AzureStorage.csproj | Changed package reference from System.Linq.Async to System.Linq.AsyncEnumerable |
| src/DurableTask.AzureStorage/OrchestrationSessionManager.cs | Added StringComparer.Ordinal parameter to ToDictionaryAsync call |
| tools/DurableTask.props | Added SuppressTfmSupportBuildWarnings property |
| samples/DistributedTraceSample/OpenTelemetry/OpenTelemetrySample.csproj | Added SuppressTfmSupportBuildWarnings property |
| samples/DistributedTraceSample/ApplicationInsights/ApplicationInsightsSample.csproj | Added SuppressTfmSupportBuildWarnings property |
| samples/Correlation.Samples/Correlation.Samples.csproj | Added SuppressTfmSupportBuildWarnings property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
System.Linq.Async's APIs have been incorporated into the BCL, there is a new package calledSystem.Linq.AsyncEnumerable. However, if an assembly targets .NET 10 (or uses theSystem.Linq.AsyncEnumerablepackage), the classAsyncEnumerablehas a collision.Given that the package
System.Linq.AsyncEnumerablehas a .NET Standard 2.0 target, I think we should migrate to this package to play nicely with .NET 10+(I also included
SuppressTfmSupportBuildWarningsto ignore the sort of "poison-pill" targets files. These new packages should work despite the scary warning messages)