Adding Aspire!!!!!!!!!!!!!!!!!!!!!!!!!! #2797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tommaso Stocchi <[email protected]> Co-authored-by: Damian Edwards <[email protected]> Co-authored-by: Safia Abdalla <[email protected]>
maddymontaquila
requested review from
Aniruddh25,
aaronburtle,
anushakolan,
RubenCerna2079,
souvikghosh04,
neeraj-sharma2592,
sourabh1007,
vadeveka,
Alekhya-Polavarapu and
rusamant
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR integrates .NET Aspire to provide containerized database orchestration for the Azure Data API Builder project. It adds support for both SQL Server and PostgreSQL database hosting through Aspire's application host model.
- Adds complete Aspire application host setup with containerized SQL Server and PostgreSQL databases
- Updates health check utilities to support multiple database providers through a factory pattern
- Includes comprehensive Star Trek-themed sample database schemas for both database types
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/apphost/ | New Aspire application host project with database orchestration and service configuration |
| src/Service/dab-config.json | Configuration for Data API Builder entities and relationships |
| src/Service/HealthCheck/ | Updated health check utilities to support multiple database providers |
| src/Directory.Packages.props | Added Aspire package references |
| Nuget.config | Updated package sources to include public NuGet feed |
| .aspire/settings.json | Aspire workspace configuration |
Comments suppressed due to low confidence (1)
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Aug 2, 2025
Aniruddh25
reviewed
Aug 2, 2025
Aniruddh25
reviewed
Aug 2, 2025
Aniruddh25
reviewed
Aug 2, 2025
Aniruddh25
reviewed
Aug 2, 2025
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
|
just updated @Aniruddh25 ! |
|
hey @Aniruddh25 we've solved merge conflicts. local build is fine. could you spin the actions to make sure we can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
BECAUSE I AM COOL
What is this change?
Aspirification
How was this tested?
Blood, sweat, and tears
Sample Request(s)
aspire runbaby