Prevent empty input node generation in mutation builder. #2729

Alekhya-Polavarapu · 2025-06-16T23:24:37Z

Why make this change?

Currently today when the tables has only autogenerated fileds, then the schema generation is failing with an error saying that "Empty input for create and update mutation input".
Error trace:
For more details look at the Errors property.\r\n\r\n1. InputObject CreateNewTableInput has no fields declared. (HotChocolate.Types.InputObjectType)\r\n2. InputObject UpdateNewTableInput has no fields declared.

#2739

What is this change?

This PR addresses the issue by conditionally generating create and update mutation input types only when the table contains at least one non-auto-generated field. This ensures that the schema remains valid and avoids generating empty input objects.

How was this tested?

Unit tests
Manual testing

screenshots

For create:

for update:

Copilot

Pull Request Overview

This PR refactors the GraphQL mutation builders for update/patch and create operations by converting several input type generation methods to return nullable values and adding corresponding null checks. Key changes include updating method signatures to support nullable returns, inserting conditional blocks to handle cases where input types may not be generated, and adjusting related logic in both UpdateAndPatchMutationBuilder and CreateMutationBuilder.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Service.GraphQLBuilder/Mutations/UpdateAndPatchMutationBuilder.cs	Updated method signatures (e.g. GenerateUpdateInputType and GetComplexInputType) and added null checks to improve null safety when generating update/patch input types.
src/Service.GraphQLBuilder/Mutations/CreateMutationBuilder.cs	Updated method signatures (e.g. GenerateCreateInputTypeForRelationalDb and GenerateComplexInputTypeForRelationalDb) and added conditional checks to ensure that input objects are only used when successfully created.

Comments suppressed due to low confidence (2)

src/Service.GraphQLBuilder/Mutations/UpdateAndPatchMutationBuilder.cs:95

Consider defining 'inputFields' as a List rather than a List<InputValueDefinitionNode?> if null values are not expected. This change would eliminate the need to use the null-forgiving operator and improve type safety.

List<InputValueDefinitionNode> inputFieldsList = inputFields.Select(i => i!).ToList();

src/Service.GraphQLBuilder/Mutations/CreateMutationBuilder.cs:77

Consider updating the declaration of 'inputFields' to use a non-nullable list if null entries are not expected. This revision would remove the need for the null-forgiving operator and enhance code clarity.

inputFields.AddRange(inputFields!)

Alekhya-Polavarapu · 2025-06-16T23:26:17Z

/azp

azure-pipelines · 2025-06-16T23:26:24Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Alekhya-Polavarapu · 2025-06-23T17:57:22Z

/azp run

azure-pipelines · 2025-06-23T17:57:44Z

Azure Pipelines successfully started running 6 pipeline(s).

RubenCerna2079 · 2025-06-24T21:57:06Z

/azp run

azure-pipelines · 2025-06-24T21:57:28Z

Azure Pipelines successfully started running 6 pipeline(s).

RubenCerna2079 · 2025-06-24T23:21:45Z

src/Service.GraphQLBuilder/Mutations/CreateMutationBuilder.cs

+                        inputFields!
+                    );


nit:

Suggested change

inputFields!

);

inputFields!);

RubenCerna2079 · 2025-06-26T17:37:08Z

src/Service.GraphQLBuilder/Mutations/CreateMutationBuilder.cs

-        /// <returns>A GraphQL input type with all expected fields mapped as GraphQL inputs.</returns>
-        private static InputObjectTypeDefinitionNode GenerateCreateInputTypeForRelationalDb(
+        /// <returns>An optional GraphQL input type with all expected fields mapped as GraphQL inputs.</returns>
+        private static InputObjectTypeDefinitionNode? GenerateCreateInputTypeForRelationalDb(


Just out of curiosity, I am not entirely sure how the mutation builder works for non-relational databases. So do you think this might also be a bug that could be found there? If so then it would also be a good idea to change the GenerateCreateInputTypeForNonRelationalDb function.

RubenCerna2079 · 2025-06-26T19:26:00Z

src/Service.GraphQLBuilder/Mutations/UpdateAndPatchMutationBuilder.cs

                    location: null,
                    new NameNode(INPUT_ARGUMENT_NAME),
                    new StringValueNode($"Input representing all the fields for updating {name}"),
                    new NonNullTypeNode(new NamedTypeNode(input.Name)),
                    defaultValue: null,
                    new List<DirectiveNode>()));
+


nit: remove line

RubenCerna2079 · 2025-06-26T19:29:42Z

src/Service.Tests/GraphQLBuilder/MutationBuilderTests.cs

+                entityPermissionsMap: _entityPermissions
+                );


Suggested change

entityPermissionsMap: _entityPermissions

);

entityPermissionsMap: _entityPermissions);

RubenCerna2079 · 2025-06-26T19:33:50Z

src/Service.Tests/GraphQLBuilder/MutationBuilderTests.cs

+            DocumentNode mutationRoot = MutationBuilder.Build(
+                root,
+                entityNameToDatabasetype,
+                new(new Dictionary<string, Entity> { { "Foo", GenerateEmptyEntity() } }),


Suggested change

new(new Dictionary<string, Entity> { { "Foo", GenerateEmptyEntity() } }),

new (new Dictionary<string, Entity> { { "Foo", GenerateEmptyEntity() } }),

RubenCerna2079 · 2025-06-26T19:35:38Z

@Alekhya-Polavarapu could you update the description for the PR? I see that you wanted to create some new lines but it shows as \r\n\r\n

Aniruddh25 · 2025-06-27T00:49:43Z

src/Service.GraphQLBuilder/Mutations/UpdateAndPatchMutationBuilder.cs

+            if (inputFields.Any())
+            {
+                List<InputValueDefinitionNode> inputFieldsList = inputFields
+                    .Select(i => i!)


what if the inputFields IEnumerable contains some null and some non-null fields based on if GenerateSimpleType returns null or non-null? Can we still safely cast it to ignore the null by doing i => i! ?

Aniruddh25

Looks good overall, but waiting for clarification on one of the comments.

Aniruddh25 · 2025-06-27T00:53:50Z

/azp run

azure-pipelines · 2025-06-27T00:54:11Z

Azure Pipelines successfully started running 6 pipeline(s).

Alekhya-Polavarapu added 3 commits June 4, 2025 17:00

modify create and update mutation input

6f9e94f

modify create and update mutation input

3b790a4

Merge branch 'main' into dev/alpolava/primarykey

56672c4

Copilot AI review requested due to automatic review settings June 16, 2025 23:24

Alekhya-Polavarapu requested review from Aniruddh25, aaronburtle, anushakolan, RubenCerna2079, sezal98, souvikghosh04, ravishetye, neeraj-sharma2592, sourabh1007, vadeveka and rusamant as code owners June 16, 2025 23:24

Copilot AI reviewed Jun 16, 2025

View reviewed changes

Alekhya-Polavarapu changed the title ~~Dev/alpolava/primarykey~~ [Draft] Prevent empty input node generation in mutation builder. Jun 16, 2025

modify create and update mutation input

ca683c6

mutation builder tests

8696fc0

Alekhya-Polavarapu changed the title ~~[Draft] Prevent empty input node generation in mutation builder.~~ Prevent empty input node generation in mutation builder. Jun 24, 2025

RubenCerna2079 linked an issue Jun 24, 2025 that may be closed by this pull request

[Bug]: Invalid Empty Node generation for Create and Update Mutation Input #2739

Open

1 task

RubenCerna2079 added this to the Backlog milestone Jun 25, 2025

Merge branch 'main' into dev/alpolava/primarykey

8d1df55

RubenCerna2079 reviewed Jun 26, 2025

View reviewed changes

Aniruddh25 reviewed Jun 27, 2025

View reviewed changes

Aniruddh25 requested changes Jun 27, 2025

View reviewed changes

Merge branch 'main' into dev/alpolava/primarykey

61dfd65

	entityPermissionsMap: _entityPermissions
	);
	entityPermissionsMap: _entityPermissions);

	new(new Dictionary<string, Entity> { { "Foo", GenerateEmptyEntity() } }),
	new (new Dictionary<string, Entity> { { "Foo", GenerateEmptyEntity() } }),

Prevent empty input node generation in mutation builder. #2729

Are you sure you want to change the base?

Prevent empty input node generation in mutation builder. #2729

Uh oh!

Conversation

Alekhya-Polavarapu commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why make this change?

What is this change?

How was this tested?

screenshots

For create:

for update:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Alekhya-Polavarapu commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

Alekhya-Polavarapu commented Jun 23, 2025

Uh oh!

azure-pipelines bot commented Jun 23, 2025

Uh oh!

RubenCerna2079 commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

RubenCerna2079 Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

RubenCerna2079 commented Jun 26, 2025

Uh oh!

Aniruddh25 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Aniruddh25 left a comment

Choose a reason for hiding this comment

Uh oh!

Aniruddh25 commented Jun 27, 2025

Uh oh!

azure-pipelines bot commented Jun 27, 2025

Uh oh!

Uh oh!

Alekhya-Polavarapu commented Jun 16, 2025 •

edited

Loading