-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Remove six and msrest dependencies #41239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove six and msrest dependencies #41239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to simplify dependency management by removing the msrest and six dependencies from the Azure ML SDK setup configuration.
- Removed msrest dependency from the install_requires list.
- Removed six dependency and its associated TODO comment.
Comments suppressed due to low confidence (2)
sdk/ml/azure-ai-ml/setup.py:71
- Please ensure that any code using msrest has been updated to use an alternative, as the dependency has been removed.
"msrest>=0.6.18,<1.0.0",
sdk/ml/azure-ai-ml/setup.py:89
- Verify that all usages of six have been removed or replaced since its dependency and the associated TODO comment have been removed.
"six>=1.11.0",
jayesh-tanna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify the significance of six package in sdk and through author who introduce this.
…into dependencyRemove
|
Corresponding Run of samples: Azure/azureml-examples#3616 |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines