Skip to content

Conversation

@kshitij-microsoft
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings May 21, 2025 07:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to simplify dependency management by removing the msrest and six dependencies from the Azure ML SDK setup configuration.

  • Removed msrest dependency from the install_requires list.
  • Removed six dependency and its associated TODO comment.
Comments suppressed due to low confidence (2)

sdk/ml/azure-ai-ml/setup.py:71

  • Please ensure that any code using msrest has been updated to use an alternative, as the dependency has been removed.
"msrest>=0.6.18,<1.0.0",

sdk/ml/azure-ai-ml/setup.py:89

  • Verify that all usages of six have been removed or replaced since its dependency and the associated TODO comment have been removed.
"six>=1.11.0",

Copy link
Member

@jayesh-tanna jayesh-tanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the significance of six package in sdk and through author who introduce this.

@kshitij-microsoft
Copy link
Member Author

Corresponding Run of samples: Azure/azureml-examples#3616

@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-ai-ml

@kshitij-microsoft kshitij-microsoft merged commit d19ad28 into Azure:main Jul 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants