Onboard Azure.Provisioning.HealthcareApis - #62967
Open
RuiJun Hu (MSFT) (cxznmhdcxz) wants to merge 4 commits into
Open
RuiJun Hu (MSFT) (cxznmhdcxz) wants to merge 4 commits into
RuiJun Hu (MSFT) (cxznmhdcxz) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1599ed09-4d96-4b96-8129-6c4aa2b8fb83
|
Azure Pipelines: Successfully started running 1 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
RuiJun Hu (MSFT) (cxznmhdcxz)
marked this pull request as ready for review
September 15, 2026 03:12
RuiJun Hu (MSFT) (cxznmhdcxz)
requested review from
a team,
Dapeng Zhang (ArcturusZhang),
Arthur Ma (ArthurMa1978),
Jesse Squire (jsquire) and
m-nash
as code owners
September 15, 2026 03:12
|
Azure Pipelines: Successfully started running 1 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
RuiJun Hu (MSFT) (cxznmhdcxz)
September 15, 2026 03:12
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Moderate generated API typing and private-endpoint mapping issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds the new Azure.Provisioning.HealthcareApis beta package with generated provisioning resources, models, tests, documentation, metadata, and CI integration.
Changes:
- Adds generated Healthcare APIs resources and models.
- Adds package configuration, API listings, README, and TypeSpec source pin.
- Adds unit/live tests and CI registration.
File summaries
| File | Reviewed change |
|---|---|
sdk/healthcareapis/cspell.yaml |
Adds spelling configuration. |
sdk/healthcareapis/ci.mgmt.yml |
Registers the package in CI. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/tsp-location.yaml |
Pins the TypeSpec source. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/tests/BasicLiveHealthcareApisTests.cs |
Adds live validation coverage. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/tests/BasicHealthcareApisTests.cs |
Adds provisioning generation coverage. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/tests/Azure.Provisioning.HealthcareApis.Tests.csproj |
Defines test dependencies. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/StorageIndexingConfiguration.cs |
Adds generated storage indexing settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/SmartIdentityProviderConfiguration.cs |
Adds generated SMART identity configuration. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/SmartIdentityProviderApplication.cs |
Adds generated SMART identity applications. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/SmartDataAction.cs |
Adds generated SMART data actions. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/ServiceExportConfigurationInfo.cs |
Adds generated export configuration details. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/PrivateEndpointConnectionProperties.cs |
Adds generated private endpoint connection properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/PrivateEndpoint.cs |
Adds generated private endpoint details. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/IotDestinationProperties.cs |
Adds generated IoT destination properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/ImplementationGuidesConfiguration.cs |
Adds generated implementation guide settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisWorkspaceProperties.cs |
Moderate (2 votes): private endpoint mappings use the service resource type/path instead of the workspace mapping. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceStorageConfiguration.cs |
Moderate (3 votes): StorageResourceId should use ResourceIdentifier rather than string. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceProperties.cs |
Adds generated Healthcare service properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceOciArtifactEntry.cs |
Adds generated OCI artifact entries. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceImportConfiguration.cs |
Adds generated service import settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceCosmosDBConfiguration.cs |
Moderate (3 votes): KeyVaultKeyUri should use Uri rather than string; this also applies at line 56. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceCorsConfiguration.cs |
Adds generated service CORS settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceAuthenticationConfiguration.cs |
Adds generated service authentication settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceAcrConfiguration.cs |
Adds generated service registry configuration. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisServiceAccessPolicyEntry.cs |
Adds generated service access policies. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisPublicNetworkAccess.cs |
Adds generated network access values. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisProvisioningState.cs |
Adds generated provisioning states. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisPrivateLinkServiceConnectionState.cs |
Adds generated private link connection state. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisPrivateLinkResourceProperties.cs |
Adds generated private link properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisPrivateEndpointServiceConnectionStatus.cs |
Adds generated private endpoint statuses. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisPrivateEndpointConnectionProvisioningState.cs |
Adds generated private endpoint provisioning states. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisKind.cs |
Adds generated service kind values. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisIotMappingProperties.cs |
Adds generated IoT mapping properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisIotIdentityResolutionType.cs |
Adds generated IoT identity resolution values. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisIotFhirDestinationProperties.cs |
Adds generated IoT FHIR destination properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisIotConnectorProperties.cs |
Adds generated IoT connector properties. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/HealthcareApisIotConnectorEventHubIngestionConfiguration.cs |
Adds generated Event Hubs ingestion settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceResourceVersionPolicyConfiguration.cs |
Adds generated FHIR history policy configuration. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceProperties.cs |
Moderate (2 votes): private endpoint mappings use the service resource type/path instead of the workspace mapping. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceKind.cs |
Adds generated FHIR service kind values. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceImportConfiguration.cs |
Adds generated FHIR import settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceExportConfiguration.cs |
Adds generated FHIR export settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceEventState.cs |
Adds generated FHIR event states. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceCorsConfiguration.cs |
Adds generated FHIR CORS settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceAuthenticationConfiguration.cs |
Adds generated FHIR authentication settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirServiceAcrConfiguration.cs |
Adds generated FHIR registry configuration. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/FhirResourceVersionPolicy.cs |
Adds generated FHIR version policy values. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/EncryptionCustomerManagedKeyEncryption.cs |
Adds generated customer-managed key settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/Encryption.cs |
Adds generated encryption settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/DicomServiceProperties.cs |
Moderate (2 votes): private endpoint mappings use the service resource type/path instead of the workspace mapping. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/DicomServiceCorsConfiguration.cs |
Adds generated DICOM CORS settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Models/DicomServiceAuthenticationConfiguration.cs |
Adds generated DICOM authentication settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Internal/CodeGenTypeAttribute.cs |
Adds generated type metadata. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Internal/CodeGenSuppressAttribute.cs |
Adds generated suppression metadata. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Internal/CodeGenSerializationAttribute.cs |
Adds generated serialization metadata. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Internal/CodeGenMemberAttribute.cs |
Adds generated member metadata. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/Internal/CodeGenEnumValueAttribute.cs |
Adds generated enum metadata. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisWorkspacePrivateLinkResource.cs |
Nit (1 vote): summary incorrectly describes a private endpoint connection resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisWorkspacePrivateEndpointConnection.cs |
Generates workspace private endpoint connections. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisWorkspace.cs |
Generates the workspace resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisServicePrivateLinkResource.cs |
Nit (1 vote): summary incorrectly describes a private endpoint connection resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisServicePrivateEndpointConnection.cs |
Generates service private endpoint connections. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisService.cs |
Generates the Healthcare service resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisIotFhirDestination.cs |
Moderate (3 votes): etag should use BicepValue<ETag> rather than BicepValue<string>. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/HealthcareApisIotConnector.cs |
Generates the IoT connector resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/FhirService.cs |
Moderate (3 votes): etag should use BicepValue<ETag> rather than BicepValue<string>. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated/DicomService.cs |
Generates the DICOM resource. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Azure.Provisioning.HealthcareApis.csproj |
Defines the package project and version. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/README.md |
Adds package usage documentation. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/metadata.json |
Declares package metadata and API version. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/Directory.Build.props |
Configures package build settings. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/CHANGELOG.md |
Adds beta release history. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/Azure.Provisioning.HealthcareApis.slnx |
Adds the package solution. |
sdk/healthcareapis/Azure.Provisioning.HealthcareApis/api/Azure.Provisioning.HealthcareApis.netstandard2.0.cs |
Lists the public API. |
Review details
- Files reviewed: 15/76 changed files
- Comments generated: 7
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
| } | ||
|
|
||
| /// <summary> Gets or sets the ETag. </summary> | ||
| public BicepValue<string> ETag |
| } | ||
|
|
||
| /// <summary> Gets or sets the ETag. </summary> | ||
| public BicepValue<string> ETag |
| private DicomServiceAuthenticationConfiguration _authenticationConfiguration; | ||
| private DicomServiceCorsConfiguration _corsConfiguration; | ||
| private BicepValue<Uri> _serviceUri; | ||
| private BicepList<HealthcareApisServicePrivateEndpointConnection> _privateEndpointConnections; |
| private FhirServiceAuthenticationConfiguration _authenticationConfiguration; | ||
| private FhirServiceCorsConfiguration _corsConfiguration; | ||
| private FhirServiceExportConfiguration _exportConfiguration; | ||
| private BicepList<HealthcareApisServicePrivateEndpointConnection> _privateEndpointConnections; |
| } | ||
|
|
||
| /// <summary> Gets or sets the KeyVaultKeyUri. </summary> | ||
| public BicepValue<string> KeyVaultKeyUri |
| } | ||
|
|
||
| /// <summary> Gets or sets the StorageResourceId. </summary> | ||
| public BicepValue<string> StorageResourceId |
| public partial class HealthcareApisWorkspaceProperties : ProvisionableConstruct | ||
| { | ||
| private BicepValue<HealthcareApisProvisioningState> _provisioningState; | ||
| private BicepList<HealthcareApisServicePrivateEndpointConnection> _privateEndpointConnections; |
Provisioning schema extractor outputPackage: Schema extracted from generated and custom source# Provisioning Resource Schema
Package: `/home/runner/work/azure-sdk-for-net/azure-sdk-for-net/sdk/healthcareapis/Azure.Provisioning.HealthcareApis`
Source: `/home/runner/work/azure-sdk-for-net/azure-sdk-for-net/sdk/healthcareapis/Azure.Provisioning.HealthcareApis/src/Generated`
## DicomService
- Resource type: `Microsoft.HealthcareApis/workspaces/dicomservices`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/DicomService.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Tags` | `tags` | DictionaryProperty | `BicepDictionary<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | True | True | `` | False |
| `Properties` | `properties` | ModelProperty | `DicomServiceProperties` | False | False | `` | False |
| `ETag` | `etag` | Property | `BicepValue<ETag>` | False | True | `` | False |
| `Identity` | `identity` | ModelProperty | `ManagedServiceIdentity` | False | True | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisWorkspace` | True | True | `` | True |
## FhirService
- Resource type: `Microsoft.HealthcareApis/workspaces/fhirservices`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/FhirService.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Tags` | `tags` | DictionaryProperty | `BicepDictionary<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | True | True | `` | False |
| `Properties` | `properties` | ModelProperty | `FhirServiceProperties` | False | False | `` | False |
| `ETag` | `etag` | Property | `BicepValue<string>` | False | True | `` | False |
| `Identity` | `identity` | ModelProperty | `ManagedServiceIdentity` | False | True | `` | False |
| `Kind` | `kind` | Property | `BicepValue<FhirServiceKind>` | False | True | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisWorkspace` | True | True | `` | True |
## HealthcareApisIotConnector
- Resource type: `Microsoft.HealthcareApis/workspaces/iotconnectors`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisIotConnector.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Tags` | `tags` | DictionaryProperty | `BicepDictionary<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | True | True | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisIotConnectorProperties` | False | False | `` | False |
| `ETag` | `etag` | Property | `BicepValue<ETag>` | False | True | `` | False |
| `Identity` | `identity` | ModelProperty | `ManagedServiceIdentity` | False | True | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisWorkspace` | True | True | `` | True |
## HealthcareApisIotFhirDestination
- Resource type: `Microsoft.HealthcareApis/workspaces/iotconnectors/fhirdestinations`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisIotFhirDestination.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisIotFhirDestinationProperties` | True | False | `` | False |
| `ETag` | `etag` | Property | `BicepValue<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | False | True | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisIotConnector` | True | True | `` | True |
## HealthcareApisService
- Resource type: `Microsoft.HealthcareApis/services`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisService.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Tags` | `tags` | DictionaryProperty | `BicepDictionary<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | True | True | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisServiceProperties` | False | True | `` | False |
| `Kind` | `kind` | Property | `BicepValue<HealthcareApisKind>` | True | True | `` | False |
| `ETag` | `etag` | Property | `BicepValue<ETag>` | False | True | `` | False |
| `Identity` | `identity` | ModelProperty | `ManagedServiceIdentity` | False | True | `` | False |
## HealthcareApisServicePrivateEndpointConnection
- Resource type: `Microsoft.HealthcareApis/services/privateEndpointConnections`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisServicePrivateEndpointConnection.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Properties` | `properties` | ModelProperty | `PrivateEndpointConnectionProperties` | False | False | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisService` | True | True | `` | True |
## HealthcareApisServicePrivateLinkResource
- Resource type: `Microsoft.HealthcareApis/services/privateLinkResources`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisServicePrivateLinkResource.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisPrivateLinkResourceProperties` | False | False | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisService` | True | True | `` | True |
## HealthcareApisWorkspace
- Resource type: `Microsoft.HealthcareApis/workspaces`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisWorkspace.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Tags` | `tags` | DictionaryProperty | `BicepDictionary<string>` | False | True | `` | False |
| `Location` | `location` | Property | `BicepValue<AzureLocation>` | True | True | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisWorkspaceProperties` | False | True | `` | False |
| `ETag` | `etag` | Property | `BicepValue<ETag>` | False | True | `` | False |
## HealthcareApisWorkspacePrivateEndpointConnection
- Resource type: `Microsoft.HealthcareApis/workspaces/privateEndpointConnections`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisWorkspacePrivateEndpointConnection.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Properties` | `properties` | ModelProperty | `PrivateEndpointConnectionProperties` | False | False | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisWorkspace` | True | True | `` | True |
## HealthcareApisWorkspacePrivateLinkResource
- Resource type: `Microsoft.HealthcareApis/workspaces/privateLinkResources`
- Default API version: `2025-04-01-preview`
- Source file: `src/Generated/HealthcareApisWorkspacePrivateLinkResource.cs`
| Property | Path | Kind | Type | Required | Settable | Default | Metadata |
| --- | --- | --- | --- | --- | --- | --- | --- |
| `Id` | `id` | Property | `BicepValue<string>` | False | False | `` | False |
| `Name` | `name` | Property | `BicepValue<string>` | True | True | `` | False |
| `SystemData` | `systemData` | ModelProperty | `SystemData` | False | False | `` | False |
| `Properties` | `properties` | ModelProperty | `HealthcareApisPrivateLinkResourceProperties` | False | False | `` | False |
| `Parent` | `parent` | Resource | `HealthcareApisWorkspace` | True | True | `` | True |
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Provisioning SDK Review Summary
- Scope:
sdk/healthcareapis/Azure.Provisioning.HealthcareApis(new onboarding package:.slnx, src/tests csproj, README, CHANGELOG, metadata.json, API listings,tsp-location.yaml, generated resources/models undersrc/Generated/, unit + live tests,sdk/healthcareapis/ci.mgmt.yml,sdk/healthcareapis/cspell.yaml) - Classification: onboarding
- CI: pass (
net - pullrequestsucceeded on head commitfc6a1553) - Schema and metadata correctness: pass, with existing findings already tracked
- Compatibility: not applicable (new package, no
ApiCompatBaseline.txt/BackwardCompatibleneeded) - Tests/snippets/docs: pass
Reviewed the onboarding of Azure.Provisioning.HealthcareApis 1.0.0-beta.1: package layout (.slnx, src/tests csproj, README, CHANGELOG, metadata, tsp-location.yaml) follows the standard provisioning package structure, and the package is correctly registered in sdk/healthcareapis/ci.mgmt.yml. BasicHealthcareApisTests.cs uses a #region Snippet:HealthcareApisBasic block with Trycep.Compare(), BasicLiveHealthcareApisTests.cs reuses the same factory method for live validation, and the README references the same snippet region. CHANGELOG.md documents the initial beta release.
Ran the trusted schema extractor (Get-ProvisioningSchema.ps1 -Format Markdown) against the generated resources and cross-checked HealthcareApisWorkspace/FhirService/DicomService/private-endpoint and private-link resources against the Microsoft Learn Bicep reference for Microsoft.HealthcareApis. Resource types, required/settable name fields, singleton constraints, and parent/scope metadata modeling are consistent with the Bicep reference (e.g. HealthcareApisWorkspaceProperties.PublicNetworkAccess settable while ProvisioningState/PrivateEndpointConnections are read-only outputs, matching the documented WorkspaceProperties shape).
The existing copilot-pull-request-reviewer[bot] review already flags the schema/type issues found during this pass and were not duplicated here:
FhirService.ETag/HealthcareApisIotFhirDestination.ETaguseBicepValue<string>while sibling resources (DicomService,HealthcareApisIotConnector,HealthcareApisService,HealthcareApisWorkspace) useBicepValue<ETag>.DicomServiceProperties.PrivateEndpointConnections,FhirServiceProperties.PrivateEndpointConnections, andHealthcareApisWorkspaceProperties.PrivateEndpointConnectionsare typed asBicepList<HealthcareApisServicePrivateEndpointConnection>, whoseParent/resource type/path point toHealthcareApisService(Microsoft.HealthcareApis/services/privateEndpointConnections) rather than the DICOM/FHIR/workspace-scoped private endpoint connection resource and path.HealthcareApisServiceCosmosDBConfiguration.KeyVaultKeyUriandHealthcareApisServiceStorageConfiguration.StorageResourceIdare typedBicepValue<string>instead ofUri/ResourceIdentifieralternate types used elsewhere in the package.
No new blocking provisioning SDK review findings on this head commit.
Analyzed by Azure .NET Provisioning SDK PR Review: commit fc6a1553899985647adcd66cbbaab54051b0024d
Analyzed by Azure .NET Provisioning SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/34926063408
There was a problem hiding this comment.
Provisioning SDK Review Summary
Same status as the previous provisioning SDK review: onboarding of Azure.Provisioning.HealthcareApis passes review with no blocking issues. No new provisioning SDK review findings on this head commit.
Verified that the two follow-up commits (24ec9b2 "update property type", aad8e8b "fix mapping") resolved all three items flagged in the previous review:
FhirService.ETag/HealthcareApisIotFhirDestination.ETagnow useBicepValue<ETag>consistently with sibling resources.HealthcareApisServiceCosmosDBConfiguration.KeyVaultKeyUriis nowBicepValue<Uri>andHealthcareApisServiceStorageConfiguration.StorageResourceIdis nowBicepValue<ResourceIdentifier>.DicomServiceProperties,FhirServiceProperties, andHealthcareApisWorkspaceProperties.PrivateEndpointConnectionsnow consistently reference the sharedHealthcareApisPrivateEndpointConnectionconstruct (output-only, no separate resource type/parent), resolving the prior service-scoped mapping mismatch.
Analyzed by Azure .NET Provisioning SDK PR Review: commit aad8e8bcbc30ad4dd6d4ccb33be3477b14a8d180
Analyzed by Azure .NET Provisioning SDK PR Review: https://github.com/Azure/azure-sdk-for-net/actions/runs/34955496745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeSpec
Validation