Bump management generator base version - #62963
Open
Dapeng Zhang (ArcturusZhang) wants to merge 9 commits into
Open
Dapeng Zhang (ArcturusZhang) wants to merge 9 commits into
Dapeng Zhang (ArcturusZhang) wants to merge 9 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 204a5049-bd52-4eaa-8d56-8a89da54c191
|
Azure Pipelines: Successfully started running 2 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Dapeng Zhang (ArcturusZhang)
marked this pull request as ready for review
September 14, 2026 08:37
Dapeng Zhang (ArcturusZhang)
requested review from
a team,
Arthur Ma (ArthurMa1978),
JoshLove-msft,
Jorge Rangel (jorgerangel-msft),
Jesse Squire (jsquire),
Wei Hu (live1206),
m-nash and
Mike Harder (mikeharder)
as code owners
September 14, 2026 08:37
|
Azure Pipelines: Successfully started running 2 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dapeng Zhang (ArcturusZhang)
September 14, 2026 08:37
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved paging, dependency alignment, and generated-dashboard issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the management generator to newer Azure/TypeSpec emitter dependencies, regenerates management fixtures, and increases emitter test timeouts.
Changes:
- Bumps generator and TypeSpec dependency versions.
- Refreshes the dependency lockfile and generated fixtures.
- Increases the emitter hook timeout.
Review findings:
- Moderate (3 votes): Direct TypeSpec pins remain outdated, causing duplicate versions and use of an older Spector CLI.
- Critical (3 votes): Continuation POST requests omit the original content.
- Moderate (1 vote): A content guard is always true, potentially emitting a content type without a body.
- Moderate (1 vote each): Relative continuation tokens fail in synchronous and asynchronous paging.
- Nit (1 vote): The generated emitter version dashboard remains stale.
File summaries
| File | Reviewed change |
|---|---|
eng/packages/http-client-csharp-mgmt/package.json |
Updated emitter and TypeSpec dependencies. |
eng/packages/http-client-csharp-mgmt/package-lock.json |
Refreshed dependency lockfile. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/RestOperations/PagingRestOperations.cs |
Regenerated paging operation fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/CollectionResults/PagingPostActionPagingCollectionResultOfT.cs |
Regenerated synchronous paging collection fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/CollectionResults/PagingPostActionPagingAsyncCollectionResultOfT.cs |
Regenerated asynchronous paging collection fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/ArmOperationTemplatesModelFactory.cs |
Regenerated Spector model factory. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/large-header/tspCodeModel.json |
Refreshed TypeSpec code model fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmProfile.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentPropertiesComplianceStatus.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentProperties.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentProperties.cs |
Regenerated model fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentComplianceStatus.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentComplianceStatus.cs |
Regenerated model fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/NestedFooModel.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/MultiFlattenProperties.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentPropertiesMachineComplianceStatus.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentProperties.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentProperties.cs |
Regenerated model fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentMachineComplianceStatus.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentMachineComplianceStatus.cs |
Regenerated model fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/FooProperties.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/ComputeFleetVmProfile.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/CapacityReservationProfile.Serialization.cs |
Regenerated model serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/MgmtTypeSpecTestsModelFactory.cs |
Regenerated local model factory. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/FooData.Serialization.cs |
Regenerated data serialization fixture. |
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec-MultiService/src/Generated/MgmtTypeSpecMultiServiceTestsModelFactory.cs |
Regenerated multi-service model factory. |
eng/packages/http-client-csharp-mgmt/emitter/vitest.config.ts |
Increased emitter hook timeout. |
eng/centralpackagemanagement/Directory.Generation.Packages.props |
Updated the management generator version. |
Review details
Files not reviewed (1)
- eng/packages/http-client-csharp-mgmt/package-lock.json: Generated file
Suppressed comments (1)
eng/centralpackagemanagement/Directory.Generation.Packages.props:4
- The auto-generated emitter dashboard is still stale: it records the previous management dependency (
1.0.0-alpha.20260828.4) even though this change updates the generator to1.0.0-alpha.20260911.2. Please regenerate and includedoc/GeneratorVersions/Emitter_Version_Dashboard.md; the file itself documents that it must be refreshed after dependency changes.
<AzureGeneratorVersion>1.0.0-alpha.20260911.2</AzureGeneratorVersion>
- Files reviewed: 4/31 changed files
- Comments generated: 2
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@azure-typespec/http-client-csharp1.0.0-alpha.20260911.2AzureGeneratorVersionand regenerate management test projectsValidation
npm ci