Skip to content

Bump management generator base version - #62963

Open
Dapeng Zhang (ArcturusZhang) wants to merge 9 commits into
Azure:mainfrom
ArcturusZhang:arcturus/bump-mgmt-base-version
Open

Dapeng Zhang (ArcturusZhang) wants to merge 9 commits into
Azure:mainfrom
ArcturusZhang:arcturus/bump-mgmt-base-version

Conversation

@ArcturusZhang

Copy link
Copy Markdown
Member

Summary

  • update the management emitter to @azure-typespec/http-client-csharp 1.0.0-alpha.20260911.2
  • align the compatible unbranded emitter and TypeSpec dependency set
  • update AzureGeneratorVersion and regenerate management test projects
  • increase the emitter hook timeout to accommodate the newer compiler startup cost

Validation

  • npm ci
  • emitter build, lint, and Prettier
  • management generator build and fixture regeneration
  • 371 management generator tests
  • 15 Spector tests
  • 145 emitter tests

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 204a5049-bd52-4eaa-8d56-8a89da54c191
@github-actions github-actions Bot added CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library. labels Sep 14, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved paging, dependency alignment, and generated-dashboard issues must be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the management generator to newer Azure/TypeSpec emitter dependencies, regenerates management fixtures, and increases emitter test timeouts.

Changes:

  • Bumps generator and TypeSpec dependency versions.
  • Refreshes the dependency lockfile and generated fixtures.
  • Increases the emitter hook timeout.

Review findings:

  • Moderate (3 votes): Direct TypeSpec pins remain outdated, causing duplicate versions and use of an older Spector CLI.
  • Critical (3 votes): Continuation POST requests omit the original content.
  • Moderate (1 vote): A content guard is always true, potentially emitting a content type without a body.
  • Moderate (1 vote each): Relative continuation tokens fail in synchronous and asynchronous paging.
  • Nit (1 vote): The generated emitter version dashboard remains stale.
File summaries
File Reviewed change
eng/packages/http-client-csharp-mgmt/package.json Updated emitter and TypeSpec dependencies.
eng/packages/http-client-csharp-mgmt/package-lock.json Refreshed dependency lockfile.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/RestOperations/PagingRestOperations.cs Regenerated paging operation fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/CollectionResults/PagingPostActionPagingCollectionResultOfT.cs Regenerated synchronous paging collection fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/CollectionResults/PagingPostActionPagingAsyncCollectionResultOfT.cs Regenerated asynchronous paging collection fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/operation-templates/src/Generated/ArmOperationTemplatesModelFactory.cs Regenerated Spector model factory.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/http/azure/resource-manager/large-header/tspCodeModel.json Refreshed TypeSpec code model fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmProfile.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentPropertiesComplianceStatus.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentProperties.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentProperties.cs Regenerated model fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentComplianceStatus.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/VmConfigurationAssignmentComplianceStatus.cs Regenerated model fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/NestedFooModel.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/MultiFlattenProperties.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentPropertiesMachineComplianceStatus.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentProperties.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentProperties.cs Regenerated model fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentMachineComplianceStatus.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/HcrpConfigurationAssignmentMachineComplianceStatus.cs Regenerated model fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/FooProperties.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/ComputeFleetVmProfile.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/Models/CapacityReservationProfile.Serialization.cs Regenerated model serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/MgmtTypeSpecTestsModelFactory.cs Regenerated local model factory.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/FooData.Serialization.cs Regenerated data serialization fixture.
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec-MultiService/src/Generated/MgmtTypeSpecMultiServiceTestsModelFactory.cs Regenerated multi-service model factory.
eng/packages/http-client-csharp-mgmt/emitter/vitest.config.ts Increased emitter hook timeout.
eng/centralpackagemanagement/Directory.Generation.Packages.props Updated the management generator version.
Review details

Files not reviewed (1)

  • eng/packages/http-client-csharp-mgmt/package-lock.json: Generated file

Suppressed comments (1)

eng/centralpackagemanagement/Directory.Generation.Packages.props:4

  • The auto-generated emitter dashboard is still stale: it records the previous management dependency (1.0.0-alpha.20260828.4) even though this change updates the generator to 1.0.0-alpha.20260911.2. Please regenerate and include doc/GeneratorVersions/Emitter_Version_Dashboard.md; the file itself documents that it must be refreshed after dependency changes.
    <AzureGeneratorVersion>1.0.0-alpha.20260911.2</AzureGeneratorVersion>
  • Files reviewed: 4/31 changed files
  • Comments generated: 2
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.

Comment thread eng/packages/http-client-csharp-mgmt/package.json
Comment thread eng/packages/http-client-csharp-mgmt/emitter/vitest.config.ts Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CodeGen Issues that relate to code generation Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants