-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix jarsigner PKIX error for non-exportable AKV certificates via AIA chain completion #47977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
45
commits into
main
Choose a base branch
from
copilot/fix-jarsigner-certificate-chain-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
09c2470
Initial plan
Copilot e350f9c
Add test to verify certificate chain ordering
Copilot abd4b84
Implement certificate chain ordering fix for jarsigner compatibility
Copilot 20d4789
Address code review feedback - improve test assertions
Copilot 10558b6
Fix SpotBugs warning - remove redundant null check
Copilot 8a27801
Merge branch 'main' into copilot/fix-jarsigner-certificate-chain-issue
rujche ced0c80
Complete certificate chain via AIA extension for non-exportable certi…
rujche b617925
Update CHANGELOG for AIA certificate chain fix
rujche 48a456b
Add INFO/WARNING logs for AIA chain completion cases
rujche 9c41b3a
Address code review feedback
rujche 8d600da
fix: Apply code review feedback on certificate chain completion
rujche b20362f
fix: Rename test methods to follow camelCase naming convention
rujche a21661b
refactor: Change AIA chain completion logs to DEBUG level
rujche b36c3b3
feat: Add debug logging for certificate chains
rujche 89369d8
fix: Address security and accuracy issues in certificate chain comple…
rujche b329fec
fix: Handle cross-signed certificates and improve exception handling
rujche a450155
fix: Address remaining Checkstyle and design issues in certificate ch…
rujche 7bf6cd2
fix: Properly handle extra certificates in AIA chain completion
rujche 1ba3cc7
fix: Correct duplicate certificate detection in AIA chain completion
rujche f259b3e
fix: Improve leaf certificate selection to avoid order-dependency
rujche 422793c
fix: Add system property to disable AIA chain completion for security
rujche ec732c8
docs: Update CHANGELOG and README with AIA disable option
rujche 69b3afc
style: Rename system property to use hyphens for consistency
rujche a8d0ee2
test: Add unit test for disable-aia-download system property
rujche e32635b
fix: Address review comments - heading hierarchy and improved JavaDoc
rujche 40c913a
fix: Wrap long JavaDoc line to comply with 120-char line limit
rujche cc0b5da
fix: Improve error handling and eliminate property name duplication
rujche dfb602c
fix: Improve duplicate detection and DN comparison in logging
rujche c8e8ac4
fix: Use signature-based issuer check instead of subject-DN-only dupl…
rujche 9431d0b
fix: Add GoodLoggingCheck suppression for CertificateUtil.java
rujche 012218b
fix: Remove string concatenation from LOGGER.log calls; restore suppr…
rujche f783342
fix: Log caught exception in getBytes() to aid AIA failure diagnosis
rujche afa848c
fix: Improve orderCertificateChain to handle incomplete [root, leaf] …
rujche f854c12
fix: Add @AfterEach cleanup for system property in AiaCertificateChai…
rujche 6e692c4
fix: Improve leaf selection and chain ordering with signature-based v…
rujche 192126b
fix: Address Copilot review comments on maxDownloads logic and logging
rujche 5029434
fix: Force sequential execution in AiaCertificateChainTest to prevent…
rujche 23dd9a3
fix: Address Copilot review comments - remove unused variables, log e…
rujche f7ec169
fix: Address Copilot review comments - remove unused variables, log e…
rujche f63c3f2
fix: validate issuer key usage and select matching cert from AIA bundles
rujche 180037f
fix: align certificate chain self-signed diagnostics with verification
rujche 1af60d6
fix: narrow issuer validation catch for spotbugs
rujche 13b16b1
fix: split long AIA log messages for checkstyle line length
rujche 4e6727f
fix: align chain-end docs and strengthen single-cert edge-case test
rujche 85af4f9
Merge branch 'main' into copilot/fix-jarsigner-certificate-chain-issue
rujche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.