Skip to content

Refactor(sqlvirtualmachine): migrate to unified folder structure #36849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor(sqlvirtualmachine): migrate to unified folder structure #36849

wants to merge 1 commit into from

Conversation

v-xuto
Copy link
Member

@v-xuto v-xuto commented Aug 21, 2025

This PR migrates the sqlvirtualmachine specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under resource-manager/Microsoft.SqlVirtualMachine/SqlVirtualMachine
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Added suppressions.yaml for legacy API versions
  • Verified TypeSpec compilation works correctly

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.SqlVirtualMachine-SqlVirtualMachine
TypeSpec Microsoft.SqlVirtualMachine
Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine
C# Azure.ResourceManager.SqlVirtualMachine
Java com.azure.resourcemanager:azure-resourcemanager-sqlvirtualmachine
JavaScript @azure/arm-sqlvirtualmachine

@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Python-Sdk labels Aug 21, 2025
@v-xuto v-xuto added Approved-Avocado Approved-LintDiff Approved-ModelValidation BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. FolderMigrationV2 A specific label for PRs like folder structure migration into v2. BreakingChange-Python-Sdk-Approved BreakingChange-Go-Sdk-Suppression-Approved labels Aug 21, 2025
@v-xuto v-xuto marked this pull request as ready for review August 21, 2025 03:29
@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 21, 2025
@v-xuto v-xuto added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 21, 2025
@qiaozha qiaozha added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha qiaozha approved these changes

Assignees
No one assigned
Labels
Approved-Avocado Approved-LintDiff Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required FolderMigrationV2 A specific label for PRs like folder structure migration into v2. PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-xuto @qiaozha