[Do not merge] [Test] Tsp gen SRP swagger migration test #28314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueww
requested review from
wyunchi-ms,
dolauli,
isra-fel,
grizzlytheodore,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh and
Pan-Qi
as code owners
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
|
blueww
changed the title
blueww
force-pushed
the
TSPmigration-SDK
branch
from
840fab5 to
1396859
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Storage PowerShell module from using the 2024-01-01 API version to the new 2025-01-01 API version, representing a migration from Swagger specifications to TSP (TypeSpec) format. The changes include API version updates, documentation improvements, and configuration adjustments.
- Updated API version from 2024-01-01 to 2025-01-01 across all storage services
- Migrated from individual Swagger JSON files to a consolidated OpenAPI specification
- Enhanced documentation with additional parameter descriptions and clarifications
Reviewed Changes
Copilot reviewed 15 out of 278 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Get-AzStorageFileServiceUsage.Recording.json | Updated test recording to use 2025-01-01 API version |
| Get-AzStorageAccountMigration.Recording.json | Updated test recording to use 2025-01-01 API version |
| generate-info.json | Updated generation ID for new build |
| Documentation files (*.md) | Added UUID requirement descriptions and improved parameter documentation |
| UX configuration files (*.json) | Updated API versions and resource type configurations |
| README.md | Migrated from multiple Swagger files to consolidated OpenAPI specification |
| Properties/AssemblyInfo.cs | Added empty line at end of file |
Comments suppressed due to low confidence (1)
src/Storage/Storage.Autorest/README.md:36
- The API version 2025-01-01 may not exist yet. As of my knowledge cutoff in January 2025, this version was not available. Please verify that this API version has been officially released.
- https://github.com/blueww/azure-rest-api-specs/blob/ec65b60fa0dc4ff769722bdb46e4c494d035cf56/specification/storage/resource-manager/Microsoft.Storage/stable/2025-01-01/openapi.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't review it.
This is just for a test, to validate the SRP swagger -> TSP migration in Azure/azure-rest-api-specs#35403
Several issues :
"x-ms-external": true,to swagger "CloudError" and "CloudErrorBody", or PSH build will fail with "'CloudError' is an ambiguous reference between 'Microsoft.Azure.Management.Storage.Models.CloudError' and 'Microsoft.Rest.Azure.CloudError'". Temp workaround by update TSP gen swagger (not update TSP). Track official fix in Migrate Storage from swagger to TypeSpec azure-rest-api-specs#35403 (comment)Besides that, has run SRP regression test, all cases pass excepted keyvault related cases failed which is expected since roleassignment fail recently.