Skip to content

[Az.Network] Add new cmdlet: Set-AzNetworkManagerIpamPoolStaticCidr #28297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

p-thompson
Copy link
Member

@p-thompson p-thompson commented Jul 29, 2025

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1498

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 20:54
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new PowerShell cmdlet Set-AzNetworkManagerIpamPoolStaticCidr for updating static CIDR allocations in Azure Network Manager IPAM pools. The cmdlet allows users to modify properties of existing static CIDR allocations such as descriptions and address prefixes.

Key changes:

  • Adds new Set cmdlet implementation with mutual exclusivity logic for address prefixes and IP allocation count
  • Includes comprehensive help documentation with usage examples
  • Updates module exports and test coverage

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
SetAzNetworkManagerIpamPoolStaticCidrCommand.cs Core cmdlet implementation with validation and mutual exclusivity logic
Set-AzNetworkManagerIpamPoolStaticCidr.md Complete help documentation with parameter descriptions and examples
Az.Network.psd1 Module manifest update to export the new cmdlet
Az.Network.md Module help index update with cmdlet reference
NetworkManagerTests.ps1 Test scenario addition for the new cmdlet functionality
Comments suppressed due to low confidence (1)

@YanaXu
Copy link
Contributor

YanaXu commented Jul 30, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Jul 30, 2025

Looks the PoolName here in the example should be Name. That probably is the reason why CI fails, @p-thompson could you help check and update?

@NoriZC NoriZC self-assigned this Jul 30, 2025
@p-thompson p-thompson changed the title Add new cmdlet: Set-AzNetworkManagerIpamPoolStaticCidr [Az.Network] Add new cmdlet: Set-AzNetworkManagerIpamPoolStaticCidr Jul 30, 2025
@YanaXu
Copy link
Contributor

YanaXu commented Jul 31, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Aug 5, 2025

Hi @p-thompson Could you please help update the changelog as well?

Copy link

github-actions bot commented Aug 5, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@p-thompson
Copy link
Member Author

Hi @p-thompson Could you please help update the changelog as well?

Added under 'Upcoming Release' please let me know if it belongs elsewhere, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants