Add missing configuration properties for the Timer Trigger annotation #154
Conversation
|
@amamounelsayed Can you please review this PR. |
|
@MayankBargali-MSFT @PramodValavala-MSFT thanks for this PR. Is there any SLA for this PR? |
|
@amamounelsayed @TsuyoshiUshio Just checking in for reviewing this and sharing feedback. Thanks! |
|
Any info on when will this be merged? Thank you. |
|
Come on guys - I have to work. Can you please merge the PR? |
|
It’s been more than a year. Still not prioritised this? |
| * Defines the value indicating whether the schedule should be monitored. | ||
| * @return The value indicating whether the schedule should be monitored. | ||
| */ | ||
| boolean useMonitor() default false; |
There was a problem hiding this comment.
Please reference to this link on useMonitor: https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-timer?tabs=csharp#configuration
So here is one concern:
if the schedule interval > 1 min then default value for useMonitor is true
if customer set false --> function.json will not have useMonitor(tested on local) --> host will set the useMonitor default value to true, this is not what customer want right.
The runOnStartup LGTM. So I wonder can you separate this PR to two, so we can merge the fix for runOnStartup and for useMonitor we can revisit and discuss the change and design. Thanks.
There was a problem hiding this comment.
@PramodValavala-MSFT can you please follow the comment and create a separate PR for runOnStartup only? We really need this functionality to prevent unwanted executions in production.
Thanks
|
Any update on this missing properties? (runOnStartup and useMonitor ) |
8 participants
The Timer Trigger annotation is missing the
runOnStartupanduseMonitorproperties that are covered in the documentation.Without these, I believe the only workaround today is to update the generated
function.jsondirectly in the JAR.