Skip to content

Conversation

@kshyju
Copy link
Member

@kshyju kshyju commented Dec 17, 2025

Move Crank additional arguments from pipeline variables to pipeline parameters to allow per-run customization. Also publish all generated outputs, including any trace files, as pipeline artifacts.

Sample run: https://azfunc.visualstudio.com/internal/_build/results?buildId=252501&view=results

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copilot AI review requested due to automatic review settings December 17, 2025 19:54
@kshyju kshyju requested a review from a team as a code owner December 17, 2025 19:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Crank benchmark pipeline to make additional arguments configurable per pipeline run rather than using hardcoded pipeline variables. It also enhances artifact publishing to capture all outputs including trace files for better debugging and analysis.

  • Moves Crank additional arguments from pipeline variables to pipeline parameters with a default value
  • Consolidates all benchmark outputs (results and trace files) into a single trace directory and publishes them as artifacts
  • Adds explicit directory creation step for the artifact output path

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/ci/templates/official/jobs/run-benchmarks.yml Adds crankAdditionalArguments parameter, introduces traceDirectory variable, updates artifact publishing to include all outputs with always() condition, and adds directory creation step
eng/ci/host.benchmarks.yml Defines crankAdditionalArguments parameter with default values and passes it to all benchmark job templates

@kshyju kshyju merged commit ad281d0 into dev Dec 17, 2025
9 checks passed
@kshyju kshyju deleted the shkr/collect_trace branch December 17, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants