{AKS} Fix remaining CLI Runner test failures - #33856
Merged
Julie Zhu (yanzhudd) merged 3 commits intoAug 7, 2026
Merged
Conversation
Avoid retry formatting of inline JSON, initialize Container Insights workspaces before AKS creation, wait between sequential VMS pool operations, and skip live scenarios whose service toggles are unavailable in the runner subscription. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
August 6, 2026 03:43
Collaborator
|
AKS |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Artifact Streaming is GA and Control Plane Metrics is on the GA rollout path, so retain their live coverage instead of masking API-version and toggle-rollout failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates AKS scenario tests to address remaining CLI Runner live-test failures by avoiding accidental str.format interpolation of inline JSON, ensuring prerequisite Container Insights resources exist before cluster creation, and adding waits to reduce flakiness between sequential nodepool autoscaler operations.
Changes:
- Pass the Container Insights solution JSON via a registered
kwargsplaceholder ({container_insights_solution}) instead of embedding JSON directly in the formatted command string. - Create the Log Analytics workspace/solution before running the MSI monitoring-addon cluster create, and pass
--workspace-resource-id. - Add
az aks wait --updatedcalls between sequential VirtualMachines autoscaler/nodepool operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_provisioning_retry.py |
Adds a unit test asserting Container Insights solution JSON is passed via a registered scenario kwarg (not inlined into the command string). |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py |
Updates live scenario logic to use kwarg-based solution JSON, pre-create workspace for monitoring-addon MSI scenario, and adds waits between autoscaler operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gate the VMS autoscaler settle checks to live and recording runs so existing replay cassettes do not issue unrecorded GET requests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Julie Zhu (yanzhudd)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aksDescription
Fix the actionable failures observed in CLI Runner run
0c9345bc-24dd-493a-bab5-1ddce36bf31a:str.formatplaceholders;Artifact Streaming and Control Plane Metrics scenarios remain enabled. AKS RP investigation found that their failures reflect API-version and deployed-toggle rollout issues rather than deprecated features.
Testing Guide
AZURE_CONFIG_DIR=/tmp/clean-config VIRTUAL_ENV=/workspace/aenv \ /workspace/aenv/bin/azdev test acs --no-exitfirstResult:
980 passed, 84 skipped, 4 subtests passed.Result: pylint and flake8 passed.
The exact Python 3.12/3.14 CI failure was also reproduced and verified with:
Result:
30 passed, 5 subtests passed.History Notes
None. Test-only changes.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.