{AKS} Fix remaining CLI Runner live test failures - #33848
Merged
Julie Zhu (yanzhudd) merged 2 commits intoAug 5, 2026
Conversation
Handle generic ARM provisioning-state responses, expand targeted transient conflict retries, preserve feature rollout regions, and update dynamic version and Automatic SKU test assumptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
August 5, 2026 00:34
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Prepare monitoring workspaces, preserve replay coverage for unsupported maintenance APIs, use a viable Automatic region, and serialize network-isolated migration reimaging. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a test-infrastructure follow-up for az aks CLI Runner live-test stability, addressing remaining AKS live-run failures by improving provisioning-state polling, expanding transient-conflict retry matching, and making several scenario setup steps more robust (version selection, region handling, and monitoring workspace preparation).
Changes:
- Fix provisioning-state polling to also read
properties.provisioningStatefrom generic ARMaz resource showresponses. - Expand the transient operation-conflict retry matcher to cover additional observed AKS “in-progress/updating” conflict messages, and add unit coverage for those cases.
- Add helpers and test updates to pick the latest
KubernetesOfficial-supported version, preserve feature-required regions, and create a Log Analytics workspace/Container Insights solution for monitoring-related scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_provisioning_retry.py |
Adds unit coverage for nested ARM provisioning state polling, expanded transient-conflict retry messages, and official-version selection. |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py |
Implements nested provisioning-state polling, expands transient-conflict detection, adds official-version/workspace helpers, and updates live/replay scenarios accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Julie Zhu (yanzhudd)
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az aksDescription
Follow up on the AKS CLI Runner live run
a8927490-05a9-4bea-9d6e-13057bfbd6c8(49 failed / 196 passed / 30 skipped) after the previous stability fixes merged.This change addresses the remaining actionable failures:
properties.provisioningStatefrom genericaz resource showresponses. The previous poll loop read only the top-level property, causing 34 tests to time out withFinal state: None.KubernetesOfficialfor LocalDNS and network-isolated tests. Current AKS versions can support both official and LTS plans, so excluding all LTS-capable versions returned no version.--no-ssh-keyexplicitly for Automatic SKU, choose a viable Automatic candidate size/region, and prepare a Container Insights workspace before cluster creation.record_only()because their old and new payload shapes are rejected by the current public live API.This is test-infrastructure-only and does not change customer-facing command behavior.
Testing Guide
Focused unit/replay tests:
Result:
31 passed, 12 subtests passed.Live verification used subscription
79a7390d-3a85-432d-9f6f-a11a703c8b83withAZURE_CLI_TEST_RETRY_PROVISIONING_CHECK=true:SucceededAutomatic cluster with metrics enabled incentralus; the local test later hit an interactive Microsoft Graph token-protection challenge, which the workload-identity CLI Runner does not use.Creatingfor over an hour. The updated sequence is covered by command/replay validation.k8s-extensiondependency environment, not the core CLI change.All changed files pass
python -m py_compileandgit diff --check.History Notes
None (test infrastructure only).
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.