{Core} Add CommandPreserveCasing and CommandIndexRebuild telemetry properties for command rebuild analysis #32451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @DanielMicrosoft, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
DanielMicrosoft
modified the milestones:
January 2026 (2026-01-06),
December 2025 (2025-12-02)
️✔️AzureCLI-BreakingChangeTest
|
DanielMicrosoft
changed the title
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
DanielMicrosoft
requested review from
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
Copilot finished reviewing on behalf of
DanielMicrosoft
November 24, 2025 07:05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new telemetry properties to support command rebuild analysis: CommandPreserveCasing (preserving the original casing of user-entered commands) and CmdIdxRebuildTriggered (indicating whether command index rebuild was triggered during execution).
Key Changes
- Added
roughly_parse_command_with_casing()utility function to parse commands while preserving original casing, complementing the existingroughly_parse_command()function - Updated telemetry session to track two new properties for command rebuild analysis
- Added comprehensive unit tests for both the existing and new command parsing functions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli-core/azure/cli/core/util.py | Added new roughly_parse_command_with_casing() function to extract command parts while preserving original user input casing |
| src/azure-cli-core/azure/cli/core/tests/test_util.py | Added comprehensive unit tests for both roughly_parse_command() and roughly_parse_command_with_casing(), including security tests to ensure sensitive flag values aren't captured |
| src/azure-cli-core/azure/cli/core/telemetry.py | Added two new telemetry properties (command_preserve_casing and cmd_idx_rebuild_triggered) with supporting functions to track command rebuild metrics |
| src/azure-cli-core/azure/cli/core/commands/init.py | Updated command execution to capture command with preserved casing early in the pipeline and pass it to telemetry tracking |
| src/azure-cli-core/azure/cli/core/init.py | Added telemetry tracking when module discovery triggers command index rebuild |
| .vscode/launch.json | Updated debug configuration to use debugpy type and removed deprecated debugOptions (appears unrelated to the PR's main purpose) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DanielMicrosoft
modified the milestones:
December 2025 (2025-12-02),
January 2026 (2026-01-06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
ADO Task: https://msazure.visualstudio.com/One/_workitems/edit/35931568
Checklist:
helpcommand--helpcommandHelpcommand (does it case/re-build?)--Helpcommand (does it case/re-build?)--version(does it case/re-build?)--Versioncommand (does it case/re-build?)versioncommand (does it case/re-build?)Versioncommand (does it case/re-build?)Verify with
something help/--helpAdd meaningful tests for above conditions.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.