Conversation
rajesh-gali
previously approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Expands Rust integration test coverage for AES/AES-XTS key property validation in the AZIHSM SDK test suite, with additional cases around usage flags, metadata, and unwrap “fail-fast” behavior.
Changes:
- Added many new
#[session_test]cases for AES/AES-XTS key generation property validation (usage flags, key sizes, class/session). - Added additional unwrap-with-props tests intended to ensure invalid props fail before reaching DDI.
- Added a few
HsmKeyPropsBuilderbehavior tests (missing fields, duplicate flag override).
You can also share your feedback on Copilot code review. Take the survey.
meilu-git
force-pushed
the
meilu/key_prop_tests
branch
from
68706cb to
29338ce
Compare
meilu-git
force-pushed
the
meilu/key_prop_tests
branch
from
29338ce to
89a8fbe
Compare
rajesh-gali
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.