Skip to content

fix: update build instructions for provider #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenstopp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update build instructions for provider #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea2e69
fix: update build instructions for provider
jenstopp Mar 6, 2026
d254c04
fix: update OpenSSL version in build instructions for provider
jenstopp Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plugins/ossl_prov/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ The provider consists of two shared libraries. `libazihsm_api_native.so` (the Ru

```bash
# 1. Build a static OpenSSL
OPENSSL_VERSION=3.0.16
OPENSSL_VERSION=3.0.3
curl -fsSL "https://github.com/openssl/openssl/releases/download/openssl-${OPENSSL_VERSION}/openssl-${OPENSSL_VERSION}.tar.gz" \
| tar xz -C /tmp
cd /tmp/openssl-${OPENSSL_VERSION}
Expand All @@ -84,8 +84,9 @@ cd azihsm-sdk
OPENSSL_DIR=/opt/openssl-static OPENSSL_STATIC=1 \
cargo build -p azihsm_api_native --features mock

# 3. Build the provider (links against system libssl-dev)
cargo build -p azihsm_ossl_provider --features mock
# 3. Build the provider with static OpenSSL
OPENSSL_DIR=/opt/openssl-static OPENSSL_STATIC=1 \
cargo build -p azihsm_ossl_provider --features mock
Comment on lines +87 to +89
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new step text says the provider is built “with static OpenSSL”, but the build system for the provider uses CMake find_package(OpenSSL 3 REQUIRED) and links ${OPENSSL_CRYPTO_LIBRARY}. The OPENSSL_DIR/OPENSSL_STATIC environment variables set here won’t affect CMake’s OpenSSL selection (they’re for openssl-sys), so as written this is misleading and may confuse readers about what is actually static vs dynamic. Consider either (a) rewording step 3 to clarify the env vars are to ensure azihsm_api_native (built via Corrosion) links statically, while the provider uses the system OpenSSL, or (b) if the provider truly must link to the static OpenSSL, pass the appropriate CMake variables (e.g., OPENSSL_ROOT_DIR / OPENSSL_USE_STATIC_LIBS) and update the instructions accordingly.

Copilot uses AI. Check for mistakes.
```

On real hardware, omit `mock` from both build commands.
Expand Down
Loading