Skip to content

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Dec 16, 2025

# since the deserialize function is not roundtrippable, once we deserialize
# the serialized version is the same
assert model_with_callback["prop"] == [1.3, 2.4, 3.5]
assert model_with_callback["prop"] == ["1.3", "2.4", "3.5"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msyyc @tadelesh note the changes in this file. Our deserialization is now roundtrippable. I think this behavior change is valid, please let me know your thoughts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants