Skip to content

Handle RD Infra Agent and Bootloader install strings containing spaces gracefully #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murajput wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle RD Infra Agent and Bootloader install strings containing spaces gracefully #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wvd-templates/DSC/Functions.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@ function InstallRDAgents {
}

Write-Log -Message "Installing RD Infra Agent on VM $AgentInstaller"
RunMsiWithRetry -programDisplayName "RD Infra Agent" -argumentList @("/i $AgentInstaller", "/quiet", "/qn", "/norestart", "/passive", "REGISTRATIONTOKEN=$RegistrationToken") -msiOutputLogPath "C:\Users\AgentInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging
RunMsiWithRetry -programDisplayName "RD Infra Agent" -argumentList @("/i '$AgentInstaller'", "/quiet", "/qn", "/norestart", "/passive", "REGISTRATIONTOKEN=$RegistrationToken") -msiOutputLogPath "C:\Users\AgentInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging
Copy link
Contributor

@dhrump dhrump Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should first do this change in portal repo and test it and put it here


Write-Log -Message "Installing RDAgent BootLoader on VM $AgentBootServiceInstaller"
RunMsiWithRetry -programDisplayName "RDAgent BootLoader" -argumentList @("/i $AgentBootServiceInstaller", "/quiet", "/qn", "/norestart", "/passive") -msiOutputLogPath "C:\Users\AgentBootLoaderInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging
RunMsiWithRetry -programDisplayName "RDAgent BootLoader" -argumentList @("/i '$AgentBootServiceInstaller'", "/quiet", "/qn", "/norestart", "/passive") -msiOutputLogPath "C:\Users\AgentBootLoaderInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging

$bootloaderServiceName = "RDAgentBootLoader"
$startBootloaderRetryCount = 0
Expand Down