-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Defend rebrand from Egress to KnowBe4 #13325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…and it was breaking the json
@microsoft-github-policy-service agree [company="KnowBe4"] |
@microsoft-github-policy-service agree company="KnowBe4" |
|
Hi @v-maheshbh, I have copied the KnowBe4 logo into the workbooks logos folder, correct me if I'm wrong but from the error I think that should fix the failing Workbooks validation. I also saw the KQL validation failed, should I be removing the DefendAuditData.txt from the parsers folder? Will this affect anything? |
|
Hi @olliespires BasePath Format: Thanks! |
|
Hi @olliespires Kindly review the comments mentioned above. Thanks! |
Hi @v-maheshbh, Apologies I have been off for 2 weeks over the holidays, just looking at these now. Thanks |
Hi @v-maheshbh, I have made the changes requested above, can you check if you are happy with them please? Thanks! |
|
Hi @v-maheshbh , Are there any further changes I need to make here and were the last ones ok? Thanks |
|
Hi @olliespires Kindly update the file extension, as only .yaml is allowed under the Parsers folder. and renamed the workbook preview images in the below‑mentioned path as well. Also, kindly check the release notes and remove any extra dotted lines. Thanks! |
…ion query in the yaml matches the list that was in there
Hi @v-maheshbh , Thanks, I have removed that text file, was this from the old packaging flow? Cheers! |
|
Hi @olliespires
Thanks! |
Morning @v-maheshbh , Ah I see, I have updated those Thanks! |
|
Hi @olliespires Kindly update the parser file extension to .yaml in the data file.
Thanks! |
Hi @v-maheshbh , Nice, updated that Thanks! |








Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.