Use 4.16.0 version in VMSizeIsValidForVersion if we cannot parse version #4475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tof1973
requested review from
bennerv,
cadenmarchese,
fahlmant,
hawkowl,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
Tof1973
force-pushed
the
tof1973/hotfix-itn-2025-00300-2
branch
from
fcfa2b3 to
56a3ca9
Compare
hlipsig
requested changes
Nov 21, 2025
Collaborator
hlipsig
left a comment
hlipsig
left a comment
There was a problem hiding this comment.
Nit on version selected, if the data points to 4.16 then let's do what the data indicates is the better choice. I'm curious if we've worked on scoping the permanent fix and if it'll be that much longer to roll out vs a temporary solution. But I'll follow up on that separately.
| if err != nil { | ||
| return false | ||
| // return false | ||
| // As temporary fix for itn-2025-00300, we will use version 4.16 for the following check if version cannot be determined |
Collaborator
There was a problem hiding this comment.
4.16 is in EUS, why not 4.17? Is there a higher rate of install failures on 4.17 compared to 4.16?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes #itn-2025-00300
What this PR does / why we need it:
Use a 4.16.0 version when version cannot be get.
This is temporary solution, until we find proper fix