Adding new extra Dimension to include the environment in the metrics and environment filed in the logs #4473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fluentbit), and metrics to enable filtering and analysis by environment
mhsreddy
force-pushed
the
mhsreddy/add-environment-metrics-logs
branch
from
7628ca5 to
e1b6a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: https://issues.redhat.com/browse/ARO-14708
What this PR does / why we need it:
This PR introduces ENVIRONMENT_TYPE field for logs. This enables:
Filtering logs in Kusto and Dgrep by environment
Using a single production Geneva Logging Account for both prod and staging, with easy differentiation through the ENVIRONMENT_TYPE filter"
Test plan for issue:
Tested this in INT. Able to see logs with new field ENVIRONMENT_TYPE for ARORPLogs. Could not be see logs related to Hive and AROCLusterLogs as we can't create clusters in INT. Will be testing this in Staging environment to verify this.
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
The Metrics and logs should contain the Environment field in the Geneva Logs and Metrics.