Skip to content

Conversation

@Tof1973
Copy link
Collaborator

@Tof1973 Tof1973 commented Nov 19, 2025

Which issue this PR addresses:

Fixes

What this PR does / why we need it:

during itn-2025-00300, we saw that if we define a version in DefaultStream and InstalledStream, we will not have the default definition.
This PR will avoid to not have default when version is in both.

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

Copy link
Member

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with this.

To my mind this is guarding against an invalid state in our own DB. I think we shouldn't do this change and instead add validation when injecting the values and refuse to add a bad state.

Edit: After discussing this, this morning I would also add that this is changing our expected contract with the DB. The code assumed that the default version was not present anywhere else. This would change the behavior and allow it to appear in the installer versions as well. While I'm not against this idea I think the better approach would be to:

  • Collapse the ways of writing to the DB to 1 endpoint. I believe there's 2 atm. If not feasible make them use the same validation
  • Make the endpoint a complete PUT and validate the entire object as needed.
  • Then change the behavior once it's encoded if we think it's worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants