[ARO-22479] Attempt to wait for all cluster operators to settle before finishing install #4456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added
go
hawkowl
requested review from
bennerv,
cadenmarchese,
fahlmant,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
pepedocs,
rogbas,
sankur-codes,
tiguelu,
tsatam,
wanghaoran1988 and
yjst2012
as code owners
hawkowl
changed the title
Collaborator
cadenmarchese
left a comment
cadenmarchese
left a comment
There was a problem hiding this comment.
Do you mind rebasing this one so we can have MIWI test coverage as well? Other than that and my comment about a missing test, I +1 the change.
| } | ||
| } | ||
|
|
||
| func TestApiServersReadyAfterCertificateConfig(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Can we include a test for the new function clusterOperatorsHaveSettled or just modify this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-22479
What this PR does / why we need it:
Waits for all the COs to settle before finishing the install. May need more work (checking revisions, etc)
Test plan for issue:
E2E, needs unit tests tho
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
E2E