-
Notifications
You must be signed in to change notification settings - Fork 594
fix: Standardize principal variables, improve resource group handling, and enhance local Teams dev setup #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prajwal-Microsoft
merged 98 commits into
Azure-Samples:dev
from
Pavan-Microsoft:waf-avm-fork-pk
Sep 29, 2025
Merged
fix: Standardize principal variables, improve resource group handling, and enhance local Teams dev setup #1925
Prajwal-Microsoft
merged 98 commits into
Azure-Samples:dev
from
Pavan-Microsoft:waf-avm-fork-pk
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds (Azure-Samples#1898) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]>
…pdate Azure Search Identity (Azure-Samples#1899) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Prajwal D C <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]>
…omputer Vision module
fix: Created minified the version of workbk json to reduce size f mai…
…orm recognizer module
…g system-assigned managed identity for Cognitive Services
…ve Services (Azure-Samples#1901) Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]>
…age-Only Network Access (Azure-Samples#1902) Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]>
…nments in Azure Cognitive Services
Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]>
…ocessing and integrated vectorization
…e location description
…rated vectorization
…torization and advanced image processing
…standardized naming
Prajwal-Microsoft
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates Azure principal environment variable names throughout the CI workflow and infrastructure configuration, improves deployment outputs, and enhances documentation for local Teams development. It also includes minor Makefile and deployment script fixes. The most important changes are grouped below:
CI Workflow and Environment Variable Standardization:
AZURE_PRINCIPAL_ID
,AZURE_PRINCIPAL_NAME
, andAZURE_PRINCIPAL_TYPE
toPRINCIPAL_ID
,PRINCIPAL_NAME
, andPRINCIPAL_TYPE
in.github/workflows/ci.yml
and updated all references accordingly. This standardizes variable naming across the workflow and infrastructure templates. [1] [2] [3] [4].github/workflows/ci.yml
, includingresource_group
andsolution_suffix
, and updated downstream jobs to consume these outputs for improved environment management. [1] [2] [3]Documentation Improvements:
docs/TEAMS_LOCAL_DEPLOYMENT.md
to clarify how to set local development URLs and enable multitenant mode for Teams Toolkit, making local setup instructions more explicit and user-friendly.Makefile and Deployment Script Fixes:
azd-login
target and cleaned up hardcoded PostgreSQL credential output in theMakefile
for clarity and maintainability. [1] [2]Makefile
for reliable resource cleanup.Does this introduce a breaking change?
How to Test
What to Check
Verify the pipeline