Skip to content

Conversation

Pavan-Microsoft
Copy link
Contributor

@Pavan-Microsoft Pavan-Microsoft commented Sep 28, 2025

Purpose

This pull request updates Azure principal environment variable names throughout the CI workflow and infrastructure configuration, improves deployment outputs, and enhances documentation for local Teams development. It also includes minor Makefile and deployment script fixes. The most important changes are grouped below:

CI Workflow and Environment Variable Standardization:

  • Renamed Azure principal environment variables from AZURE_PRINCIPAL_ID, AZURE_PRINCIPAL_NAME, and AZURE_PRINCIPAL_TYPE to PRINCIPAL_ID, PRINCIPAL_NAME, and PRINCIPAL_TYPE in .github/workflows/ci.yml and updated all references accordingly. This standardizes variable naming across the workflow and infrastructure templates. [1] [2] [3] [4]
  • Added new outputs to the deploy job in .github/workflows/ci.yml, including resource_group and solution_suffix, and updated downstream jobs to consume these outputs for improved environment management. [1] [2] [3]

Documentation Improvements:

  • Updated docs/TEAMS_LOCAL_DEPLOYMENT.md to clarify how to set local development URLs and enable multitenant mode for Teams Toolkit, making local setup instructions more explicit and user-friendly.

Makefile and Deployment Script Fixes:

  • Removed duplicate azd-login target and cleaned up hardcoded PostgreSQL credential output in the Makefile for clarity and maintainability. [1] [2]
  • Ensured the correct Azure environment is selected before running the destroy command in the Makefile for reliable resource cleanup.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify the pipeline

Pavan-Microsoft and others added 30 commits September 15, 2025 11:36
…ds (Azure-Samples#1898)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Ajit Padhi <[email protected]>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Ross Smith <[email protected]>
Co-authored-by: gpickett <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Prajwal D C <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
Co-authored-by: UtkarshMishra-Microsoft <[email protected]>
Co-authored-by: Priyanka-Microsoft <[email protected]>
Co-authored-by: Prasanjeet-Microsoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]>
Co-authored-by: Prashant-Microsoft <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
Co-authored-by: Avijit-Microsoft <[email protected]>
Co-authored-by: RaviKiran-Microsoft <[email protected]>
Co-authored-by: Somesh Joshi <[email protected]>
Co-authored-by: Himanshi Agrawal <[email protected]>
Co-authored-by: pradeepjha-microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Bangarraju-Microsoft <[email protected]>
Co-authored-by: Harsh-Microsoft <[email protected]>
Co-authored-by: Kanchan-Microsoft <[email protected]>
Co-authored-by: Cristopher Coronado <[email protected]>
Co-authored-by: Cristopher Coronado Moreira <[email protected]>
Co-authored-by: Vamshi-Microsoft <[email protected]>
Co-authored-by: Thanusree-Microsoft <[email protected]>
Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
…pdate Azure Search Identity (Azure-Samples#1899)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Ajit Padhi <[email protected]>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Ross Smith <[email protected]>
Co-authored-by: gpickett <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Prajwal D C <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
Co-authored-by: UtkarshMishra-Microsoft <[email protected]>
Co-authored-by: Priyanka-Microsoft <[email protected]>
Co-authored-by: Prasanjeet-Microsoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]>
Co-authored-by: Prashant-Microsoft <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
Co-authored-by: Avijit-Microsoft <[email protected]>
Co-authored-by: RaviKiran-Microsoft <[email protected]>
Co-authored-by: Somesh Joshi <[email protected]>
Co-authored-by: Himanshi Agrawal <[email protected]>
Co-authored-by: pradeepjha-microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Bangarraju-Microsoft <[email protected]>
Co-authored-by: Harsh-Microsoft <[email protected]>
Co-authored-by: Kanchan-Microsoft <[email protected]>
Co-authored-by: Cristopher Coronado <[email protected]>
Co-authored-by: Cristopher Coronado Moreira <[email protected]>
Co-authored-by: Vamshi-Microsoft <[email protected]>
Co-authored-by: Thanusree-Microsoft <[email protected]>
Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
fix: Created minified the version of workbk json to reduce size f mai…
…g system-assigned managed identity for Cognitive Services
…ve Services (Azure-Samples#1901)

Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
…age-Only Network Access (Azure-Samples#1902)

Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
@Prajwal-Microsoft Prajwal-Microsoft merged commit 9d4fa10 into Azure-Samples:dev Sep 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants