-
Notifications
You must be signed in to change notification settings - Fork 592
ci: refactor deployment workflow and env config #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Ajit Padhi <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Prajwal D C <[email protected]>
…nd Update Conversation flow based on template selection (#1567) Co-authored-by: Pavan Kumar <v-kupavan.microsoft.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pavan-Microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
…ra (#1822) Co-authored-by: Harmanpreet Kaur <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]>
…1827) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Thanusree-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Ajit Padhi <[email protected]> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Ross Smith <[email protected]> Co-authored-by: gpickett <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Francia Riesco <[email protected]> Co-authored-by: Harmanpreet-Microsoft <[email protected]> Co-authored-by: UtkarshMishra-Microsoft <[email protected]> Co-authored-by: Priyanka-Microsoft <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]> Co-authored-by: Prashant-Microsoft <[email protected]> Co-authored-by: Rohini-Microsoft <[email protected]> Co-authored-by: Avijit-Microsoft <[email protected]> Co-authored-by: RaviKiran-Microsoft <[email protected]> Co-authored-by: Somesh Joshi <[email protected]> Co-authored-by: Himanshi Agrawal <[email protected]> Co-authored-by: pradeepjha-microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]> Co-authored-by: Bangarraju-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Kanchan-Microsoft <[email protected]> Co-authored-by: Cristopher Coronado <[email protected]> Co-authored-by: Cristopher Coronado Moreira <[email protected]> Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
…grated vectorization (#1839) Co-authored-by: Vamshi-Microsoft <[email protected]> Co-authored-by: Prajwal-Microsoft <[email protected]>
…test orchestration, and improved Makefile targets (#1855) Co-authored-by: Harmanpreet Kaur <[email protected]>
…d maintenance (#1880) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Roopan P M <[email protected]> Co-authored-by: Roopan-Microsoft <[email protected]> Co-authored-by: Pavan-Microsoft <[email protected]> Co-authored-by: Prasanjeet-Microsoft <[email protected]> Co-authored-by: Harmanpreet Kaur <[email protected]>
…up e2e tests (#1884) Co-authored-by: Harmanpreet Kaur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant improvements to the CI/CD pipeline, deployment automation, and environment configuration for the project. The main changes include a comprehensive overhaul of the GitHub Actions workflow for deployment and testing, enhanced extraction and propagation of deployment URLs, improved handling of authentication and database setup, and updates to environment configuration defaults. These updates streamline deployment, improve reliability, and make the automation more robust and maintainable.
CI/CD Workflow and Deployment Automation:
Major refactor of
.github/workflows/ci.yml
:ci
todeploy
, with additional outputs for deployment status and URLs. Steps for image pre-build, deployment, URL extraction, authentication disabling, PostgreSQL setup, and status checks are added, along with a newcleanup
job for resource destruction. End-to-end tests are now triggered only if deployment succeeds, using a workflow call to the updated test automation workflow. [1] [2] [3] [4] [5] [6]The test automation workflow
.github/workflows/test-automation.yml
is changed to useworkflow_call
with required inputs forweb_url
andadmin_url
, allowing dynamic invocation from the main workflow. Environment variable handling is improved, and Python setup uses the latest action version.Deployment and Resource Extraction Enhancements:
Makefile
'sdeploy
target is rewritten for more robust Azure login, deployment, and resource extraction. It now reliably extracts frontend and admin URLs, PostgreSQL host endpoints, and provides helper targets for checking and disabling authentication.Environment Configuration Updates:
AZURE_AUTH_TYPE
incode/backend/batch/utilities/helpers/env_helper.py
is changed from"keys"
to"rbac"
, aligning with more secure authentication practices.FUNCTION_KEY
is added to the configuration loader for easier access to Azure Function keys.Other Improvements:
.github/workflows/comment_coverage.yml
..github/workflows/ci.yml
.These changes collectively make the deployment and testing process more automated, robust, and easier to maintain, with improved diagnostics and resource management.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information