Skip to content

Conversation

@JoshLozensky
Copy link
Contributor

  • Cleaning up/standardizing the test naming
  • Removing unused code
  • Removing unnecessary ToString() calls
  • Added a folder to hold Playwright traces and a .gitignore to never commit those traces

All tests still pass locally.

Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but is it possible to fix the warnings? They show up in the PR in the GitHub UI if you scroll to the bottom.

@JoshLozensky
Copy link
Contributor Author

Not related, but is it possible to fix the warnings? They show up in the PR in the GitHub UI if you scroll to the bottom.

I'll do that in another PR :)

@JoshLozensky JoshLozensky merged commit 56113b0 into master Nov 7, 2024
2 checks passed
@JoshLozensky JoshLozensky deleted the lozensky/CleanupUiTests branch November 7, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants